Fix the failure semantics of procfs_make_node

* procfs.c (procfs_make_node): Invoke the cleanup callback on
  failure, so that callers don't have to.
* procfs.h: Document the change.
* procfs_dir.c (procfs_dir_make_node), procfs_file.c
  (procfs_file_make_node), proclist.c (proclist_make_node):
  Update to reflect the change.

1 files changed, 2 insertions, 0 deletions

diff --git a/procfs.h b/procfs.h
index 0557b6d1..21b0f93d 100644
--- a/procfs.h
+++ b/procfs.h
@@ -29,6 +29,8 @@ struct procfs_node_ops
   void (*cleanup) (void *hook);
 };
 
+/* Create a new node and return it.  Returns NULL if it fails to allocate
+   enough memory.  In this case, ops->cleanup will be invoked.  */
 struct node *procfs_make_node (const struct procfs_node_ops *ops, void *hook);