summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiles Bader <miles@gnu.org>1995-12-20 23:59:16 +0000
committerMiles Bader <miles@gnu.org>1995-12-20 23:59:16 +0000
commita5acf49db7eafb084f3483f3e9c44233e08ab466 (patch)
tree17ef5b128cb80c58ae09bb03635693855e6f9762
parent6a1409b12d47f823a6e77b78823525d5ae65ee7b (diff)
(S_proc_reassign):
Have notifications sent to the correct request port. Once we've given STUBP's request port to P, don't leave it in STUBP, so process_has_exited() doesn't dealloc it.
-rw-r--r--proc/mgt.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/proc/mgt.c b/proc/mgt.c
index 0842a213..853e53db 100644
--- a/proc/mgt.c
+++ b/proc/mgt.c
@@ -208,20 +208,22 @@ S_proc_reassign (struct proc *p,
task_terminate (p->p_task);
mach_port_deallocate (mach_task_self (), p->p_task);
p->p_task = newt;
- mach_port_request_notification (mach_task_self (), p->p_task,
- MACH_NOTIFY_DEAD_NAME, 1, p->p_reqport,
- MACH_MSG_TYPE_MAKE_SEND_ONCE, &foo);
- if (foo)
- mach_port_deallocate (mach_task_self (), foo);
/* For security, we need use the request port from STUBP, and
not inherit this state. */
mach_port_mod_refs (mach_task_self (), p->p_reqport,
MACH_PORT_RIGHT_RECEIVE, -1);
p->p_reqport = stubp->p_reqport;
+ stubp->p_reqport = MACH_PORT_NULL; /* Protect from process_has_exited. */
mach_port_mod_refs (mach_task_self (), p->p_reqport,
MACH_PORT_RIGHT_RECEIVE, 1);
+ mach_port_request_notification (mach_task_self (), p->p_task,
+ MACH_NOTIFY_DEAD_NAME, 1, p->p_reqport,
+ MACH_MSG_TYPE_MAKE_SEND_ONCE, &foo);
+ if (foo)
+ mach_port_deallocate (mach_task_self (), foo);
+
/* Enqueued messages might refer to the old task port, so
destroy them. */
if (p->p_msgport != MACH_PORT_NULL)