diff options
| author | Justus Winter <4winter@informatik.uni-hamburg.de> | 2013-11-07 17:01:02 +0100 |
|---|---|---|
| committer | Justus Winter <4winter@informatik.uni-hamburg.de> | 2013-11-10 16:48:13 +0100 |
| commit | 9b02c4454abee568af9ff1d6c9044e9cd757b5aa (patch) | |
| tree | 1fc63441e9ee98b628aa970b8fbe7077b615dee4 | |
| parent | 130b51ac17f44707261f4885d2fadb44a2f5a1e5 (diff) | |
libshouldbeinlibc: fix reference counting in port_name_xlator_create
Both task ports are deallocated in the destructor, so they must be
referenced in the constructor.
* libshouldbeinlibc/portxlate.c (port_name_xlator_create): Fix
reference counting.
| -rw-r--r-- | libshouldbeinlibc/portxlate.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/libshouldbeinlibc/portxlate.c b/libshouldbeinlibc/portxlate.c index 599fb584..8888e2c2 100644 --- a/libshouldbeinlibc/portxlate.c +++ b/libshouldbeinlibc/portxlate.c @@ -35,7 +35,9 @@ port_name_xlator_create (mach_port_t from_task, mach_port_t to_task, if (! x) return ENOMEM; + mach_port_mod_refs (mach_task_self (), from_task, MACH_PORT_RIGHT_SEND, +1); x->from_task = from_task; + mach_port_mod_refs (mach_task_self (), to_task, MACH_PORT_RIGHT_SEND, +1); x->to_task = to_task; x->to_names = 0; x->to_types = 0; @@ -64,6 +66,10 @@ port_name_xlator_create (mach_port_t from_task, mach_port_t to_task, x->to_names_len * sizeof (mach_port_t)); munmap ((caddr_t) x->to_types, x->to_types_len * sizeof (mach_port_type_t)); + + mach_port_deallocate (mach_task_self (), x->to_task); + mach_port_deallocate (mach_task_self (), x->from_task); + err = ENOMEM; } } |