summaryrefslogtreecommitdiff
path: root/open_issues/gnumach_integer_overflow.mdwn
diff options
context:
space:
mode:
authorhttps://me.yahoo.com/a/g3Ccalpj0NhN566pHbUl6i9QF0QEkrhlfPM-#b1c14 <diana@web>2015-02-16 20:08:03 +0100
committerGNU Hurd web pages engine <web-hurd@gnu.org>2015-02-16 20:08:03 +0100
commit95878586ec7611791f4001a4ee17abf943fae3c1 (patch)
tree847cf658ab3c3208a296202194b16a6550b243cf /open_issues/gnumach_integer_overflow.mdwn
parent8063426bf7848411b0ef3626d57be8cb4826715e (diff)
rename open_issues.mdwn to service_solahart_jakarta_selatan__082122541663.mdwn
Diffstat (limited to 'open_issues/gnumach_integer_overflow.mdwn')
-rw-r--r--open_issues/gnumach_integer_overflow.mdwn50
1 files changed, 0 insertions, 50 deletions
diff --git a/open_issues/gnumach_integer_overflow.mdwn b/open_issues/gnumach_integer_overflow.mdwn
deleted file mode 100644
index 08a29268..00000000
--- a/open_issues/gnumach_integer_overflow.mdwn
+++ /dev/null
@@ -1,50 +0,0 @@
-[[!meta copyright="Copyright © 2012, 2013 Free Software Foundation, Inc."]]
-
-[[!meta license="""[[!toggle id="license" text="GFDL 1.2+"]][[!toggleable
-id="license" text="Permission is granted to copy, distribute and/or modify this
-document under the terms of the GNU Free Documentation License, Version 1.2 or
-any later version published by the Free Software Foundation; with no Invariant
-Sections, no Front-Cover Texts, and no Back-Cover Texts. A copy of the license
-is included in the section entitled [[GNU Free Documentation
-License|/fdl]]."]]"""]]
-
-[[!tag open_issue_gnumach]]
-
-
-# IRC, freenode, #hurd, 2012-07-04
-
- <braunr> yes, we have integer overflows on resident_page_count, but
- luckily, the member is rarely used
-
-See also [[gnumach_vm_object_resident_page_count]].
-
-
-## IRC, freenode, #hurd, 2013-06-04
-
- <elmig> this is declared as int on vm_object.h
- <elmig> and as it as counter it's always positive
- <braunr> yes it should be unsigned
- <elmig> ok
- <braunr> but leave it as it is for consistency with the rest
- <elmig> i send patch :)
- <braunr> please no
- <braunr> unless you've fully determined the side effects
- <elmig> i've grepped the vars and saw only comparisons > and = 0
- <elmig> never less than 0
- <braunr> > 0 is the same
- <braunr> well
- <braunr> > not, but >= would be a problem
- <elmig> http://paste.debian.net/plain/8527
- <elmig> asctually no >=0
- <braunr> still, i don't want to change that unless it's strictly necessary
- <braunr> hum, you're grepping ref_count, not resident_page_count
- <elmig> i did both
- <elmig> on resident_page_count theres resident_page_count >= 0
- <elmig> = 0, == 0
- <braunr> this isn't the only possible issue
- <braunr> anyway
- <braunr> for now there is no reason to change anything unless you do a full
- review
- <elmig> only place i see resdent_page_count and page_count being decreased
- it's on vm/vm_resident.c
- <elmig> vm_page_remove() and vm_page_replace()