diff options
Diffstat (limited to 'libpthread')
-rw-r--r-- | libpthread/sysdeps/hurd/pt-destroy-specific.c | 2 | ||||
-rw-r--r-- | libpthread/sysdeps/hurd/pt-getspecific.c | 4 | ||||
-rw-r--r-- | libpthread/sysdeps/hurd/pt-key-delete.c | 19 | ||||
-rw-r--r-- | libpthread/sysdeps/hurd/pt-setspecific.c | 4 | ||||
-rw-r--r-- | libpthread/tests/Makefile | 2 | ||||
-rw-r--r-- | libpthread/tests/test-7.c | 3 |
6 files changed, 31 insertions, 3 deletions
diff --git a/libpthread/sysdeps/hurd/pt-destroy-specific.c b/libpthread/sysdeps/hurd/pt-destroy-specific.c index 23c7fbc0..f7896e5e 100644 --- a/libpthread/sysdeps/hurd/pt-destroy-specific.c +++ b/libpthread/sysdeps/hurd/pt-destroy-specific.c @@ -48,7 +48,7 @@ __pthread_destroy_specific (struct __pthread *thread) void *value; if (__pthread_key_destructors[i] == PTHREAD_KEY_INVALID) - break; + continue; value = hurd_ihash_find (thread->thread_specifics, i); if (value) diff --git a/libpthread/sysdeps/hurd/pt-getspecific.c b/libpthread/sysdeps/hurd/pt-getspecific.c index 30605984..71ec63c6 100644 --- a/libpthread/sysdeps/hurd/pt-getspecific.c +++ b/libpthread/sysdeps/hurd/pt-getspecific.c @@ -27,7 +27,9 @@ pthread_getspecific (pthread_key_t key) { struct __pthread *self; - assert (key < __pthread_key_count); + if (key < 0 || key >= __pthread_key_count + || __pthread_key_destructors[key] == PTHREAD_KEY_INVALID) + return NULL; self = _pthread_self (); if (! self->thread_specifics) diff --git a/libpthread/sysdeps/hurd/pt-key-delete.c b/libpthread/sysdeps/hurd/pt-key-delete.c index 2426bb11..9d88647e 100644 --- a/libpthread/sysdeps/hurd/pt-key-delete.c +++ b/libpthread/sysdeps/hurd/pt-key-delete.c @@ -35,8 +35,27 @@ pthread_key_delete (pthread_key_t key) err = EINVAL; else { + int i; + __pthread_key_destructors[key] = PTHREAD_KEY_INVALID; __pthread_key_invalid_count ++; + + pthread_rwlock_rdlock (&__pthread_threads_lock); + for (i = 0; i < __pthread_num_threads; ++i) + { + struct __pthread *t; + + t = __pthread_threads[i]; + + if (t == NULL) + continue; + + /* Just remove the key, no need to care whether it was + already there. */ + if (t->thread_specifics) + hurd_ihash_remove (t->thread_specifics, key); + } + pthread_rwlock_unlock (&__pthread_threads_lock); } __pthread_mutex_unlock (&__pthread_key_lock); diff --git a/libpthread/sysdeps/hurd/pt-setspecific.c b/libpthread/sysdeps/hurd/pt-setspecific.c index 89ca4d7f..d0b7302f 100644 --- a/libpthread/sysdeps/hurd/pt-setspecific.c +++ b/libpthread/sysdeps/hurd/pt-setspecific.c @@ -28,6 +28,10 @@ pthread_setspecific (pthread_key_t key, const void *value) error_t err; struct __pthread *self = _pthread_self (); + if (key < 0 || key >= __pthread_key_count + || __pthread_key_destructors[key] == PTHREAD_KEY_INVALID) + return EINVAL; + if (! self->thread_specifics) { err = hurd_ihash_create (&self->thread_specifics, HURD_IHASH_NO_LOCP); diff --git a/libpthread/tests/Makefile b/libpthread/tests/Makefile index 9509c957..5ebc01d3 100644 --- a/libpthread/tests/Makefile +++ b/libpthread/tests/Makefile @@ -4,7 +4,7 @@ LDLIBS = -lpthread CHECK_SRC := test-1.c test-2.c test-3.c test-6.c test-7.c test-8.c \ test-9.c test-10.c test-11.c test-12.c test-13.c test-14.c \ - test-15.c test-16.c + test-15.c test-16.c test-17.c test-__pthread_destroy_specific-skip.c CHECK_OBJS := $(addsuffix .o,$(basename $(notdir $(CHECK_SRC)))) CHECK_PROGS := $(basename $(notdir $(CHECK_SRC))) \ diff --git a/libpthread/tests/test-7.c b/libpthread/tests/test-7.c index 8159be34..22fb1caa 100644 --- a/libpthread/tests/test-7.c +++ b/libpthread/tests/test-7.c @@ -42,6 +42,9 @@ main (int argc, char **argv) assert ((pthread_t) val == pthread_self ()); } + assert (pthread_getspecific ((pthread_key_t) 0) == NULL); + assert (pthread_setspecific ((pthread_key_t) 0, (void *) 0x1) == EINVAL); + for (i = 0; i < KEYS; i ++) err = pthread_key_create (&key[i], des); |