From 470972f3f854e92ee1cc8f1e2ada8412a2b97956 Mon Sep 17 00:00:00 2001
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Mon, 16 Jun 2014 16:50:12 +0200
Subject: trans/fakeroot: fix error handling

Found using the Clang Static Analyzer.

* trans/fakeroot.c (new_node): Do not leak a pointer to freed memory.
Store NULL at *np instead.  This fixes a node use-after-free in
netfs_S_dir_lookup.
---
 trans/fakeroot.c | 1 +
 1 file changed, 1 insertion(+)

(limited to 'trans')

diff --git a/trans/fakeroot.c b/trans/fakeroot.c
index 32a34ec4..df2de646 100644
--- a/trans/fakeroot.c
+++ b/trans/fakeroot.c
@@ -119,6 +119,7 @@ new_node (file_t file, mach_port_t idport, int locked, int openmodes,
   mach_port_deallocate (mach_task_self (), nn->idport);
   mach_port_deallocate (mach_task_self (), file);
   free (*np);
+  *np = NULL;
   return err;
 }
 
-- 
cgit v1.2.3