From e848c0dee50ba029083d8a83a38d1c4536d37362 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sat, 20 Jul 2013 17:06:25 +0200 Subject: pfinet: Fix call to kfree_s kfree_s expects a pointer and a size argument. Currently the sizeof(cache) is used as size argument, this is certainly not what was intented. For reference, this code was present in Linux up to version 2.3.14 and was replaced in 2.3.15. Found using coccinelle and https://raw.github.com/coccinelle/coccinellery/master/sz/sz.cocci. * pfinet/linux-src/net/ipv4/ipmr.c (ipmr_cache_delete): Fix kfree_s call. --- pfinet/linux-src/net/ipv4/ipmr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pfinet/linux-src/net/ipv4/ipmr.c') diff --git a/pfinet/linux-src/net/ipv4/ipmr.c b/pfinet/linux-src/net/ipv4/ipmr.c index cd51cd9a..08d1a364 100644 --- a/pfinet/linux-src/net/ipv4/ipmr.c +++ b/pfinet/linux-src/net/ipv4/ipmr.c @@ -332,7 +332,7 @@ static void ipmr_cache_delete(struct mfc_cache *cache) kfree_skb(skb); } } - kfree_s(cache,sizeof(cache)); + kfree_s(cache,sizeof(*cache)); } /* -- cgit v1.2.3