From bd7e7ae44c78bcfe623dec8636375685c8c30be3 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 11 Oct 2015 22:02:41 +0200 Subject: Drop duplicate port deallocation Follow-up dbfa8a3 * libnetfs/io-reauthenticate.c (netfs_S_io_reauthenticate): Do not deallocate parameter port `rend_port' when an error will be returned. * libtrivfs/io-reauthenticate.c (trivfs_S_io_reauthenticate): Do not deallocate parameter port `rend_port' when an error will be returned. --- libtrivfs/io-reauthenticate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'libtrivfs') diff --git a/libtrivfs/io-reauthenticate.c b/libtrivfs/io-reauthenticate.c index c75f5fcc..35775e57 100644 --- a/libtrivfs/io-reauthenticate.c +++ b/libtrivfs/io-reauthenticate.c @@ -52,7 +52,8 @@ trivfs_S_io_reauthenticate (struct trivfs_protid *cred, assert (newright != MACH_PORT_NULL); err = iohelp_reauth (&newcred->user, auth, rendport, newright, 1); - mach_port_deallocate (mach_task_self (), rendport); + if (!err) + mach_port_deallocate (mach_task_self (), rendport); mach_port_deallocate (mach_task_self (), auth); if (err) return err; -- cgit v1.2.3