From 4241dd5673566a61add85bd9eb52d4ae7db2750a Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Sat, 23 Nov 2013 16:12:55 +0100 Subject: libports: use protected payloads to optimize the object lookup * NEWS: Mention protected payloads. * libports/Makefile (SRCS): Add `port-deref-deferred.c'. * libports/create-internal.c (_ports_create_port_internal): Set the protected payload to the objects address. * libports/import-port.c (ports_import_port): Likewise. * libports/reallocate-from-external.c (ports_reallocate_from_external): Likewise. * libports/reallocate-port.c (ports_reallocate_port): Likewise. * libports/transfer-right.c (ports_transfer_right): Likewise. * libports/manage-multithread.c (ports_manage_port_operations_multithread): Use the protected payload for the object lookup if provided. Add thread pool management calls. * libports/manage-one-thread.c (ports_manage_port_operations_one_thread): Likewise. * libports/destroy-right.c (ports_destroy_right): Defer the dereferencing of outstanding send rights to avoid a port_info use-after-free. * libports/port-deref-deferred.c: New file. * libports/port-deref-deferred.h: Likewise. * libports/ports.h (struct port_bucket): New field `threadpool'. (ports_lookup_payload): Check `port_right'. --- libports/ports.h | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'libports/ports.h') diff --git a/libports/ports.h b/libports/ports.h index f02edb42..9299bc40 100644 --- a/libports/ports.h +++ b/libports/ports.h @@ -29,6 +29,8 @@ #include #include +#include "port-deref-deferred.h" + #ifdef PORTS_DEFINE_EI #define PORTS_EI #else @@ -73,6 +75,7 @@ struct port_bucket int rpcs; int flags; int count; + struct ports_threadpool threadpool; }; /* FLAGS above are the following: */ #define PORT_BUCKET_INHIBITED PORTS_INHIBITED @@ -262,6 +265,9 @@ ports_lookup_payload (struct port_bucket *bucket, { struct port_info *pi = (struct port_info *) payload; + if (pi && ! MACH_PORT_VALID (pi->port_right)) + pi = NULL; + if (pi && bucket && pi->bucket != bucket) pi = NULL; -- cgit v1.2.3