From 8058ef787e82504d0b6fab9384f1b74f72393f1a Mon Sep 17 00:00:00 2001 From: Flavio Cruz Date: Thu, 31 Dec 2015 16:45:51 +0100 Subject: Use DEVICE_IMPORTS to include libports/ports.h On Thu, Dec 31, 2015 at 04:28:14PM +0100, Justus Winter wrote: > Quoting Samuel Thibault (2015-12-31 16:11:30) > > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote: > > > This fixes three compiler warnings about ports_payload_get_name. > > > > > > * devnode/Makefile: Define DEVICE_IMPORTS. > > > * term/Makefile: Likewise. > > > * trans/Makefile: Likewise. > > > > Why not adding them to the corresponding mig-mutate.h? > > Sometimes we don't have a mig-mutate.h, e.g. for most (all?) > translators in trans/. I prefer stuffing that in a .h as well, but I > wouldn't be opposed to just applying the patch, as we use both ways of > mutating the mig types. Agreed. I think only devnode should include it in mig-mutate.h. For term, only some stubs are including mig-mutate.h. For trans, there's no mig-mutate.h at all. Here's the modified patch. --- devnode/mig-mutate.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'devnode') diff --git a/devnode/mig-mutate.h b/devnode/mig-mutate.h index 0656014f..b7a9ed60 100644 --- a/devnode/mig-mutate.h +++ b/devnode/mig-mutate.h @@ -25,3 +25,5 @@ end_using_port_info (port_info_t) #define NOTIFY_IMPORTS \ import "libports/mig-decls.h"; +#define DEVICE_IMPORTS \ + import "libports/ports.h"; -- cgit v1.2.3