From f57d72dee53c79d5d527336bfbd9455c5262e963 Mon Sep 17 00:00:00 2001 From: Olaf Buddenhagen Date: Sun, 18 Jul 2010 02:33:40 +0200 Subject: pfinet: check return value of mmap() in S_io_read() and S_socket_recv() * pfinet/io-ops.c (S_io_read): Check return value. * pfinet/socket-ops.c (S_socket_recv): Likewise. --- pfinet/io-ops.c | 5 +++++ pfinet/socket-ops.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/pfinet/io-ops.c b/pfinet/io-ops.c index bee1c19a..ef8d8513 100644 --- a/pfinet/io-ops.c +++ b/pfinet/io-ops.c @@ -87,6 +87,11 @@ S_io_read (struct sock_user *user, if (amount > *datalen) { *data = mmap (0, amount, PROT_READ|PROT_WRITE, MAP_ANON, 0, 0); + if (*data == MAP_FAILED) + /* Should check whether errno is indeed ENOMEM -- + but this can't be done in a straightforward way, + because the glue headers #undef errno. */ + return ENOMEM; alloced = 1; } diff --git a/pfinet/socket-ops.c b/pfinet/socket-ops.c index baeaad30..b9ce6c72 100644 --- a/pfinet/socket-ops.c +++ b/pfinet/socket-ops.c @@ -499,6 +499,11 @@ S_socket_recv (struct sock_user *user, if (amount > *datalen) { *data = mmap (0, amount, PROT_READ|PROT_WRITE, MAP_ANON, 0, 0); + if (*data == MAP_FAILED) + /* Should check whether errno is indeed ENOMEM -- + but this can't be done in a straightforward way, + because the glue headers #undef errno. */ + return ENOMEM; alloced = 1; } -- cgit v1.2.3