From 5534751bfc13761fd87c667cd3f3719575adac2a Mon Sep 17 00:00:00 2001
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Thu, 11 Jul 2013 18:09:05 +0200
Subject: libnetfs: fix consistency check

passive is not a zero terminated string but a char * combined with a
length. If passivelen == 0, passive may very well be not NULL, and
dereferencing that pointer might not be safe. At the very least the
consistency check is wrong. Fix that by checking passivelen instead of
passive.

* libnetfs/file-set-trans.c (netfs_S_file_set_translator): Fix sanity check.
---
 libnetfs/file-set-translator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libnetfs/file-set-translator.c b/libnetfs/file-set-translator.c
index 4c29d952..b107ccd5 100644
--- a/libnetfs/file-set-translator.c
+++ b/libnetfs/file-set-translator.c
@@ -39,7 +39,7 @@ netfs_S_file_set_translator (struct protid *user,
   if (!(passive_flags & FS_TRANS_SET) && !(active_flags & FS_TRANS_SET))
     return 0;
 
-  if (passive && passive[passivelen - 1])
+  if (passivelen && passive[passivelen - 1])
     return EINVAL;
 
   np = user->po->np;
-- 
cgit v1.2.3