From 3f38f1b21cffcf669373baff46840ce0a7d902e5 Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Fri, 20 Nov 2015 12:46:56 +0100 Subject: libfshelp: acquire references to control ports * libfshelp/translator-list.c (translator_ihash_cleanup): Release reference. (fshelp_set_active_translator): Acquire reference --- libfshelp/translator-list.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libfshelp/translator-list.c b/libfshelp/translator-list.c index c87bbaa3..e043a670 100644 --- a/libfshelp/translator-list.c +++ b/libfshelp/translator-list.c @@ -53,8 +53,7 @@ translator_ihash_cleanup (void *element, void *arg) if (translator->pi) ports_port_deref (translator->pi); - /* No need to deallocate translator->active, we only keep the name of - the port, not a reference. */ + mach_port_deallocate (mach_task_self (), translator->active); free (translator->name); free (translator); } @@ -124,8 +123,10 @@ fshelp_set_active_translator (struct port_info *pi, t->pi = pi; } - /* No need to increment the reference count, we only keep the - name, not a reference. */ + if (MACH_PORT_VALID (t->active)) + mach_port_deallocate (mach_task_self (), t->active); + mach_port_mod_refs (mach_task_self (), active, + MACH_PORT_RIGHT_SEND, +1); t->active = active; } else -- cgit v1.2.3