| Age | Commit message (Collapse) | Author |
|---|
|
This change fixes a problem that can occur with non-blocking (and also
blocking for very short times) select/poll calls. The problem occurs because
the timeout is implemented at the client side. For a non-blocking call, this
means that (depending on the code path taken in the C library) the client
could get a timeout without a full RPC round-trip to the server. Moving the
implementation of the timeout to the servers guarantees a full round-trip,
and correct results for non-blocking calls.
The modifications in this change depend on the availability of the recently
added pthread_hurd_cond_timedwait_np function in libpthread.
* boot/boot.c (io_select_common): New static function.
(S_io_select): Use io_select_common.
(S_io_select_timeout): New function which makes use of io_select_common.
* console-client/kbd-repeat.c (repeater_select): Add a timeout parameter.
* console-client/pc-mouse.c (repeater_select): Likewise.
* console-client/trans.c (io_select_common): New static function.
(netfs_S_io_select): Use io_select_common.
(netfs_S_io_select_timeout): New function which makes use of io_select_common.
* console-client/trans.h (struct consnode): Add a timeout parameter.
* hurd/io.defs (io_select_timeout): New MIG routine.
* hurd/io_reply.defs (io_select_timeout_reply): New MIG simpleroutine.
* hurd/io_request.defs (io_select_timeout_request): Likewise.
* libdiskfs/io-select.c (diskfs_S_io_select_timeout): New function.
* libnetfs/io-select.c (netfs_S_io_select_timeout): Likewise.
* libpipe/pipe.c (pipe_pair_select): Add a timeout parameter.
* libpipe/pipe.h (pipe_select_readable): Likewise.
(pipe_select_writable): Likewise.
(pipe_pair_select): Likewise.
* libpipe/pq.h: Include <hurd/hurd_types.h>.
* libtrivfs/io-select.c (trivfs_S_io_select_timeout): New function.
* pfinet/glue-include/linux/sched.h: Include <errno.h>.
(interruptible_sleep_on): Function removed, replaced with ...
(interruptible_sleep_on_timeout): New function.
(schedule): Update to use interruptible_sleep_on_timeout.
(schedule_timeout): Likewise.
* pfinet/io-ops.c (io_select_common): New static function.
(S_io_select): Use io_select_common.
(S_io_select_timeout): New function which makes use of io_select_common.
* pfinet/tunnel.c (io_select_common): New static function.
(trivfs_S_io_select): Use io_select_common.
(trivfs_S_io_select_timeout): New function which makes use of io_select_common.
* pflocal/connq.c (connq_listen): Replace noblock with a timeout parameter.
* pflocal/connq.h: Include <hurd/hurd_types.h>.
(connq_listen): Update declaration to replace noblock with a timeout parameter.
* pflocal/io.c (io_select_common): New static function.
(S_io_select): Use io_select_common.
(S_io_select_timeout): New function which makes use of io_select_common.
* pflocal/socket.c (S_socket_accept): Update call to connq_listen to match new
declaration.
* storeio/io.c (trivfs_S_io_select_timeout): New function.
* term/ptyio.c (pty_io_select): Add a timeout parameter.
* term/term.h (pty_io_select): Likewise.
* term/users.c (io_select_common): New static function.
(trivfs_S_io_select): Use io_select_common.
(trivfs_S_io_select_timeout): New function which makes use of io_select_common.
* trans/fifo.c (io_select_common): New static function.
(trivfs_S_io_select): Use io_select_common.
(trivfs_S_io_select_timeout): New function which makes use of io_select_common.
* trans/firmlink.c (trivfs_S_io_select_timeout): New function.
* trans/new-fifo.c (io_select_common): New static function.
(trivfs_S_io_select): Use io_select_common.
(trivfs_S_io_select_timeout): New function which makes use of io_select_common.
* trans/null.c (trivfs_S_io_select_timeout): New function.
* trans/streamio.c (io_select_common): New static function.
(trivfs_S_io_select): Use io_select_common.
(trivfs_S_io_select_timeout): New function which makes use of io_select_common.
|
|
* fifo.c, new-fifo.c, null.c (trivfs_S_io_map): Change return value to
EOPNOTSUPP (was EINVAL).
|
|
* firmlink.c (trivfs_S_io_read): Fix type of DATA argument.
* streamio.c (trivfs_S_io_read): Likewise.
(trivfs_S_io_write): Likewise.
* hello.c (trivfs_S_io_read): Likewise.
* hello-mt.c (trivfs_S_io_read): Likewise.
* null.c (trivfs_S_io_read): Likewise.
(trivfs_S_io_write): Likewise.
(trivfs_S_file_set_size): Add reply port args.
* null.c (trivfs_S_io_map): Add reply port args.
(trivfs_S_io_read, trivfs_S_io_write): off_t -> loff_t
(trivfs_S_file_set_size): Likewise.
(trivfs_S_io_select): Remove bogus last arg.
|
|
* symlink.c: Include <string.h> for decls of built-ins.
* firmlink.c: Include <stdlib.h> for exit decl.
* ifsock.c: Likewise.
* null.c: Likewise.
* magic.c: Likewise.
* fifo.c: Likewise.
* hello.c: Likewise.
* hello-mt.c: Likewise.
|
|
* null.c: Support --full/-f option to be /dev/full (ENOSPC writes).
(write_error_code): New variable.
(options, argp): New static const variables.
(parse_opt): New function.
(main): Move local ARGP out to static.
(trivfs_S_io_write): Return write_error_code instead of zero.
|
|
|
|
* null.c (trivfs_S_io_map): Renamed to ...
(trivfs_S_io_map_segment): ... here, with new parameter `index'.
* new-fifo.c (trivfs_S_io_map): Renamed to ...
(trivfs_S_io_map_segment): ... here, with new parameter `index'.
* fifo.c (trivfs_S_io_map): Renamed to ...
(trivfs_S_io_map_segment): ... here, with new parameter `index'.
|
|
* bogus-fifo.c (main): Deallocate bootstrap port after using it.
* fifo.c (main): Likewise.
* firmlink.c (main): Likewise.
* ifsock.c (main): Likewise.
* magic.c (main): Likewise.
* null.c (main): Likewise.
* symlink.c (main): Likewise.
|
|
* null.c (trivfs_S_io_read): Fix return value.
Reported by Steinar Hamre <steinarh@fim.ntnu.no>.
|
|
* firmlink.c (main): Fix return type to int, and use return.
* fwd.c (main): Likewise.
* new-fifo.c (main): Likewise.
* magic.c (main): Likewise.
* fifo.c (main): Likewise.
* null.c (main): Likewise.
|
|
Fix typo.
|
|
* crash.c (main): New args for
ports_manage_port_operations_multithread.
* fifo.c (main): Likewise.
* firmlink.c (main): Likewise.
* new-fifo.c (main): Likewise.
* null.c (main): Likewise.
|
|
|
|
|
|
trivfs_cntl_portclasses, trivfs_protid_nportclasses,
trivfs_cntl_nportclasses):
Variables removed.
(main):
Don't use them.
|
|
Function removed (trivfs default is now sufficient).
|
|
Always return 0.
(argp_program_version):
New variable.
(provide_zeros):
Variable removed.
(main):
Use argp for argument parsing.
(trivfs_S_io_read):
Don't return zeros anymore.
(trivfs_S_file_check_access):
New function.
|
|
|
|
|
|
|
|
(trivfs_protid_porttypes, trivfs_cntl_porttypes,
trivfs_protid_nporttypes, trivfs_cntl_nporttypes): Deleted vars.
(trivfs_protid_portclasses, trivfs_cntl_portclasses,
trivfs_protid_nportclasses, trivfs_cntl_nportclasses): New vars.
(control_class, node_class, port_bucket): New vars.
(main): Initialize control_class, node_class, port_bucket,
trivfs_protid_portclasses, and trivfs_cntl_portclasses.
(ports_cleanroutines): Delete initialization.
(main): Convert to new trivfs interface.
(trivfs_goaway): Likewise.
(main): Convert to new ports interface.
(ports_demuxer, ports_notice_idle, ports_no_live_ports,
ports_no_hard_ports): Deleted functions.
|
|
|
|
|
|
Get rid of _libports_initialize() [it gets called automatically].
|
|
|
|
run it from the shell to get a usage message.
|
|
|
