|
On Thu, Dec 31, 2015 at 04:28:14PM +0100, Justus Winter wrote:
> Quoting Samuel Thibault (2015-12-31 16:11:30)
> > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote:
> > > This fixes three compiler warnings about ports_payload_get_name.
> > >
> > > * devnode/Makefile: Define DEVICE_IMPORTS.
> > > * term/Makefile: Likewise.
> > > * trans/Makefile: Likewise.
> >
> > Why not adding them to the corresponding mig-mutate.h?
>
> Sometimes we don't have a mig-mutate.h, e.g. for most (all?)
> translators in trans/. I prefer stuffing that in a .h as well, but I
> wouldn't be opposed to just applying the patch, as we use both ways of
> mutating the mig types.
Agreed. I think only devnode should include it in mig-mutate.h. For
term, only some stubs are including mig-mutate.h. For trans, there's no
mig-mutate.h at all. Here's the modified patch.
|
