libfshelp: fix the api of fshelp_set_active_translator

To detect if an active translator goes away, we need to register for
dead name notifications. Those notifications have to be sent to a port
known to the ports library, as the ports library handles the dead name
notifications. The most straight forward way is to use the port to the
underlying node for that. To that end, a reference to the port_info
struct is handed in and kept in the list of active translators.

This commit also moves the registration of dead name notifications to
libfshelp.

* libfshelp/fshelp.h (fshelp_set_active_translator): Add port_info argument.
* libfshelp/translator-list.c (struct translator): Add port_info pointer.
(translator_ihash_cleanup): Dereference port_info object.
(fshelp_set_active_translator): Register dead name notifications.
* libdiskfs/file-set-trans.c (diskfs_S_file_set_translator): Update
  accordingly.
* libnetfs/file-set-translator.c (netfs_S_file_set_translator): Likewise.

1 files changed, 3 insertions, 15 deletions

diff --git a/libdiskfs/file-set-trans.c b/libdiskfs/file-set-trans.c
index 8de2e641..58f62550 100644
--- a/libdiskfs/file-set-trans.c
+++ b/libdiskfs/file-set-trans.c
@@ -1,5 +1,5 @@
 /* libdiskfs implementation of fs.defs: file_set_translator
-   Copyright (C) 1992,93,94,95,96,99,2001,02,13
+   Copyright (C) 1992,93,94,95,96,99,2001,02,13,14
      Free Software Foundation, Inc.
 
    This program is free software; you can redistribute it and/or
@@ -208,20 +208,8 @@ diskfs_S_file_set_translator (struct protid *cred,
 
   pthread_mutex_unlock (&np->lock);
 
-  if (! error && cred->po->path)
-    error = fshelp_set_active_translator (cred->po->path, active);
-
-  if (! error && active != MACH_PORT_NULL)
-    {
-      mach_port_t old;
-      error = mach_port_request_notification (mach_task_self (), active,
-					      MACH_NOTIFY_DEAD_NAME, 0,
-					      cred->pi.port_right,
-					      MACH_MSG_TYPE_MAKE_SEND_ONCE,
-					      &old);
-      if (old != MACH_PORT_NULL)
-	mach_port_deallocate (mach_task_self (), old);
-    }
+  if (! error && cred->po->path && active_flags & FS_TRANS_SET)
+    error = fshelp_set_active_translator (&cred->pi, cred->po->path, active);
 
   return error;
 }