libpager: use a fixed number of threads

Previously, libpager used an unbounded number of threads to receive
messages from the pager bucket.  It used sequence barriers to execute
the requests to order requests to each object.

The sequence barriers are implemented in seqnos.c.  A server function
uses _pager_wait_for_seqno to wait for its sequence number and
_pager_release_seqno to release it, or it uses _pager_update_seqno to
do both operations in one step.

These sequence barriers divide each server function in three parts: A,
B, and C.  A_i happens "before" the sequence barrier i, B_i happens
"in order", C_i happens "after" the sequence barrier.  This partial
order < has the following properties:

* This order is *per object*.  Requests to different objects are not
  ordered.

* A_i < B_i,  B_i < C_i (due to the structure of the code)

* B_i < B_{i+1} (this is due to the sequence barriers)

* Note that only the B parts are ordered by the sequence numbers, we
  are free to execute C_i and C_{i+1} in any possible order.  The same
  argument applies to the A parts.

The sequence barriers are implemented using a very simple ticket
algorithm.  Every request, even the invalid ones, is processed by a
thread, and waits until the ticket count reaches its seqno, does some
work in-order, then increments the ticket and awakes all threads that
have piled up up to this moment.  All of them except one will then
discover that it's not their turn yet and go to sleep again.

Creating one thread per request has proven to be problematic as
memory_object requests often arrive in large batches.

This patch does two things:

* Use a single thread to receive messages from the port bucket.  All
  incoming request are put into a queue.

* Use a fixed-number of threads (though even one is actually enough)
  to execute the the server functions.  If multiple threads are used,
  a work-delegation mechanism ensures that the per object order < is
  preserved.

For reference, I used the following command to create workloads that
highlight the problem this patch is addressing:

% settrans t .../ext2fs --sync=30 /dev/sd2s1
...
% /usr/bin/time zsh -c 'for ((i=0; i < 1500; i++)); do
  dd if=/dev/zero of=t/src/$i bs=4k count=290 2>/dev/null
  echo -n .
  if ((i % 100 == 0)) ; then echo -n $i; fi
done'

* libpager/queue.h: New file.
* libpager/demuxer.c: Manage a queue of requests received from the
port bucket.
(pager_demuxer): Just decode the server function and enqueue the
request.
(worker_func): New function that consumes and executes the requests
from the queue.
(service_paging_requests): New function.
(pager_start_workers): Likewise.
* libpager/data-request.c: Remove the seqno barriers.
* libpager/data-return.c: Likewise.
* libpager/data-unlock.c: Likewise.
* libpager/chg-compl.c: Likewise.
* libpager/lock-completed.c: Likewise.
* libpager/no-senders.c: Likewise.
* libpager/notify-stubs.c: Likewise.
* libpager/object-init.c: Likewise.
* libpager/object-terminate.c: Likewise.
* libpager/seqnos.c: Remove file.
* libpager/stubs.c: Likewise.
* libpager/pager.h (pager_demuxer): Drop declaration.
(pager_start_workers): New declaration.
* libpager/priv.h: Remove the _pager_seqno declarations.
* libpager/Makefile (SRCS): Drop seqnos.c.
* console/pager.c (user_pager_init): Call pager_start_workers.
* libdiskfs/disk-pager.c: Likewise.
* storeio/pager.c: Likewise.
* ext2fs/pager.c (service_paging_requests): Remove function.
(create_disk_pager): Start separate file pager using
`pager_start_workers'.
* fatfs/pager.c (service_paging_requests): Remove function.
(create_fat_pager): Start separate file pager using
`pager_start_workers'.

1 files changed, 3 insertions, 25 deletions

diff --git a/ext2fs/pager.c b/ext2fs/pager.c
index 39cf1c73..298dae7a 100644
--- a/ext2fs/pager.c
+++ b/ext2fs/pager.c
@@ -1192,21 +1192,6 @@ disk_cache_block_is_ref (block_t block)
   return ref;
 }
 
-/* A top-level function for the paging thread that just services paging
-   requests.  */
-static void *
-service_paging_requests (void *arg)
-{
-  struct port_bucket *pager_bucket = arg;
-  ports_manage_port_operations_multithread (pager_bucket,
-					    pager_demuxer,
-					    1000,
-					    0,
-					    NULL);
-  /* Not reached.  */
-  return NULL;
-}
-
 /* Create the disk pager, and the file pager.  */
 void
 create_disk_pager (void)
@@ -1231,17 +1216,10 @@ create_disk_pager (void)
   /* The file pager.  */
   file_pager_bucket = ports_create_bucket ();
 
-#define STACK_SIZE (64 * 1024)
-  pthread_attr_init (&attr);
-  pthread_attr_setstacksize (&attr, STACK_SIZE);
-#undef STACK_SIZE
-
-  /* Make a thread to service file paging requests.  */
-  err = pthread_create (&thread, &attr,
-			service_paging_requests, file_pager_bucket);
+  /* Start libpagers worker threads.  */
+  err = pager_start_workers (file_pager_bucket);
   if (err)
-    error (2, err, "pthread_create");
-  pthread_detach (thread);
+    ext2_panic ("can't create libpager worker threads: %s", strerror (err));
 }
 
 /* Call this to create a FILE_DATA pager and return a send right.