diff options
author | Justus Winter <4winter@informatik.uni-hamburg.de> | 2014-06-10 14:22:31 +0200 |
---|---|---|
committer | Justus Winter <4winter@informatik.uni-hamburg.de> | 2014-06-18 15:57:00 +0200 |
commit | 944cfdbe6cff4e8025a730228b48c1a21b4a2e33 (patch) | |
tree | 32accaee79c274514ead2fadd1a9975b2000fe8b /TODO | |
parent | 8821d8a213008eb723414c6c70de384830ea10d7 (diff) |
libdiskfs: add permission check to file_chflags
Only root is allowed to change the high 16 bits. The TODO entry says
otherwise, but that must be a mistake. For reference, see the glibc
sources, sysdeps/mach/hurd/bits/stat.h.
* libdiskfs/file-chflags.c (diskfs_S_file_chflags): Add permission
check.
* TODO (libdiskfs): Remove entry.
Diffstat (limited to 'TODO')
-rw-r--r-- | TODO | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -108,8 +108,6 @@ See `tasks', the exported task list. Rename the rest to libhurdutil or somesuch. ** libdiskfs -*** file_chflags does not do proper permission checking (non-root isn't - supposed to be able to change the low bits) *** Add the short-circuited-but-not-builtin translator startup code from dir-lookup to fsys_getroot. Compare and match carefully these two routines and then share common code. |