summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Bushnell <thomas@gnu.org>1999-06-29 08:00:50 +0000
committerThomas Bushnell <thomas@gnu.org>1999-06-29 08:00:50 +0000
commit45e9b9e5b132ab0571210a671695d1d8dcc5f882 (patch)
treea94a87c101fb0717d761f4142bda542cafc1cf76
parent544489db142ed9e4f80848777dbab78d0952b4e9 (diff)
1999-06-29 Thomas Bushnell, BSG <tb@mit.edu>
* lookup.c (diskfs_lookup): If we get an error from fshelp_checkdirmod, clear *NP as well as returning the error. Use diskfs_nrele instead of diskfs_nput in case *NP and DP are the same. 1999-06-28 Thomas Bushnell, BSG <tb@mit.edu> * dir-rmdir.c (diskfs_S_dir_rmdir): Reorganized to make clearer; several little buglets fixed too.
-rw-r--r--libdiskfs/ChangeLog10
-rw-r--r--libdiskfs/dir-rmdir.c3
-rw-r--r--libdiskfs/lookup.c8
3 files changed, 19 insertions, 2 deletions
diff --git a/libdiskfs/ChangeLog b/libdiskfs/ChangeLog
index d10ea2ef..81118fe2 100644
--- a/libdiskfs/ChangeLog
+++ b/libdiskfs/ChangeLog
@@ -1,6 +1,14 @@
+1999-06-29 Thomas Bushnell, BSG <tb@mit.edu>
+
+ * lookup.c (diskfs_lookup): If we get an error from
+ fshelp_checkdirmod, clear *NP as well as returning the error.
+ Use diskfs_nrele instead of diskfs_nput in case *NP and DP are
+ the same.
+
1999-06-28 Thomas Bushnell, BSG <tb@mit.edu>
- * dir-rmdir.c (diskfs_S_dir_rmdir): Reorganized to make clearer.
+ * dir-rmdir.c (diskfs_S_dir_rmdir): Reorganized to make clearer;
+ several little buglets fixed too.
1999-06-27 Thomas Bushnell, BSG <tb@mit.edu>
diff --git a/libdiskfs/dir-rmdir.c b/libdiskfs/dir-rmdir.c
index 314e4e0a..637c00f4 100644
--- a/libdiskfs/dir-rmdir.c
+++ b/libdiskfs/dir-rmdir.c
@@ -42,6 +42,9 @@ diskfs_S_dir_rmdir (struct protid *dircred,
if (error == EAGAIN)
error = ENOTEMPTY;
+ if (error)
+ goto out;
+
/* Attempt to rmdir(".") */
if (dnp == np)
{
diff --git a/libdiskfs/lookup.c b/libdiskfs/lookup.c
index 2dd75a92..3ec9dd87 100644
--- a/libdiskfs/lookup.c
+++ b/libdiskfs/lookup.c
@@ -183,7 +183,13 @@ diskfs_lookup (struct node *dp, const char *name, enum lookup_type type,
if (err2)
{
if (np && !err)
- diskfs_nput (*np);
+ {
+ if (*np == dp)
+ diskfs_nrele (*np);
+ else
+ diskfs_nput (*np);
+ *np = 0;
+ }
return err2;
}
}