auth: fix use of uninitialized variable err

Previously a plausible execution path existed so the value of err was
undefined at the end of the function, making the function return
arbitrary error values. Fix this by initializing it to 0.

Found using the Clang Static Analyzer.

* auth/auth.c (S_auth_server_authenticate): Initialize err to 0.

1 files changed, 1 insertions, 1 deletions

diff --git a/auth/auth.c b/auth/auth.c
index 167d8f02..91a21e45 100644
--- a/auth/auth.c
+++ b/auth/auth.c
@@ -381,7 +381,7 @@ S_auth_server_authenticate (struct authhandle *serverauth,
 {
   struct pending_user *u;
   struct authhandle *user;
-  error_t err;
+  error_t err = 0;
 
   if (! serverauth)
     return EOPNOTSUPP;