From b0fa32c1d7de74a8b83b33833640ff30c84e9fbd Mon Sep 17 00:00:00 2001
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Wed, 18 Feb 2015 06:40:07 +0100
Subject: kern: avoid #if 0ing out thread_collect_scan

Currently, `thread_collect_scan' does nothing because `pcb_collect' is
a nop.  Its body is exempt from compilation by means of the
preprocessor.

This is unfortunate as it increases the risk of bitrot, and we still
need to pay the price of rate-limiting thread_collect_scan.

* kern/thread.c (thread_collect_scan): Drop #if 0 around the body.
* vm/vm_pageout.c (vm_pageout_scan): Do not call
`consider_thread_collect' and document why.
---
 vm/vm_pageout.c | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'vm')

diff --git a/vm/vm_pageout.c b/vm/vm_pageout.c
index ecedb57..aff823a 100644
--- a/vm/vm_pageout.c
+++ b/vm/vm_pageout.c
@@ -551,6 +551,8 @@ void vm_pageout_scan(void)
 	stack_collect();
 	net_kmsg_collect();
 	consider_task_collect();
+	if (0)	/* XXX: pcb_collect doesn't do anything yet, so it is
+		   pointless to call consider_thread_collect.  */
 	consider_thread_collect();
 	slab_collect();
 
-- 
cgit v1.2.3