From 172f3ea324a3685a62b03edd8b03e5f09e265301 Mon Sep 17 00:00:00 2001
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Tue, 4 Feb 2014 11:43:41 +0100
Subject: ddb: safely copy symbol names into the symtab structure

Use strncpy instead of strcpy to copy the name of a symbol into the
symtab structure.  Make sure that the string is properly terminated.

Found using Coverity.

* ddb/db_sym.c (db_add_symbol_table): Use strncpy instead of strcpy,
ensure string termination.
---
 ddb/db_sym.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'ddb')

diff --git a/ddb/db_sym.c b/ddb/db_sym.c
index beb4d18..3c8caf4 100644
--- a/ddb/db_sym.c
+++ b/ddb/db_sym.c
@@ -75,7 +75,8 @@ db_add_symbol_table(type, start, end, name, ref, map_pointer)
 	st->end = end;
 	st->private = ref;
 	st->map_pointer = (map_pointer == (char *)kernel_map)? 0: map_pointer;
-	strcpy(st->name, name);
+	strncpy(st->name, name, sizeof st->name - 1);
+	st->name[sizeof st->name - 1] = '\0';
 
 	db_nsymtab++;
 
-- 
cgit v1.2.3