summaryrefslogtreecommitdiff
path: root/ddb
AgeCommit message (Collapse)Author
2014-02-04ddb: safely copy symbol names into the symtab structureJustus Winter
Use strncpy instead of strcpy to copy the name of a symbol into the symtab structure. Make sure that the string is properly terminated. Found using Coverity. * ddb/db_sym.c (db_add_symbol_table): Use strncpy instead of strcpy, ensure string termination.
2013-12-20Mark pure functions with attribute pureMarin Ramesa
2013-12-20ddb/db_watch.c (db_watchpoint_cmd): remove forward declarationMarin Ramesa
* ddb/db_watch.c (db_watchpoint_cmd) (db_option): Remove forward declaration.
2013-12-20Declare void argument lists (part 2)Marin Ramesa
Declare void argument lists that were not declared in the first part of this patch and * kern/sched_prim.h (recompute_priorities): Fix prototype. * kern/startup.c (setup_main) (recompute_priorities): Fix call.
2013-12-16Quiet GCC warning about uninitialized variableMarin Ramesa
* ddb/db_command.h (db_error): Mark with attribute noreturn. * i386/i386/setjmp.h (_longjmp): Likewise.
2013-12-15ddb: qualify pointers whose dereferenced values are constant with constMarin Ramesa
2013-12-15ddb/db_expr.c (db_mult_expr): initialize lhsMarin Ramesa
Initialize lhs to zero to avoid uninitialized usage in db_unary(). * ddb/db_expr.c (db_mult_expr) (lhs): Initialize to zero.
2013-12-15ddb/db_break.c (db_delete_cmd): remove unnecessary initializationMarin Ramesa
Now that we have returns there are no more warnings from GCC about uninitialized variable. Remove unnecessary initialization of variable bkpt. * ddb/db_break.c (db_delete_cmd) (bkpt): Remove unnecessary initialization.
2013-12-15ddb/db_break.c (db_find_breakpoint_here): remove unnecessary castsMarin Ramesa
Variable addr and member address are already of db_addr_t type which is type defined as vm_offset_t. * ddb/db_break.c (db_find_breakpoint_here) (DB_PHYS_EQ) (addr, address): Remove unecessary casts.
2013-12-15Declare void argument listsMarin Ramesa
2013-12-09ddb/db_trap.c (db_task_trap): remove forward declarationsMarin Ramesa
* ddb/db_break.h (db_check_breakpoint_valid): Add prototype. * ddb/db_trap.c (db_init_default_thread, db_check_breakpoint_valid): Remove forward declarations.
2013-12-09Use db_addr_t instead of db_expr_tMarin Ramesa
In this way everything falls into place and there is one cast less. Function db_task_printsym() is already always called with the cast to db_addr_t in the first argument. * ddb/db_aout.c (aout_db_line_at_pc): Use db_addr_t instead of db_expr_t. (aout_db_search_by_addr): Don't cast to vm_offset_t. Argument is already db_addr_t. * ddb/db_aout.h (aout_db_line_at_pc): Use db_addr_t instead of db_expr_t. * ddb/db_sym.c (db_task_printsym): Likewise. (db_line_at_pc): Likewise. * ddb/db_sym.h (db_task_printsym): Likewise. (db_line_at_pc): Likewise. * i386/i386/db_trace.c (db_task_printsym): Cast to db_addr_t instead of db_expr_t. Member swap_func is a pointer to void.
2013-12-09ddb/db_print.c: use unsigned long instead of an unsigned intMarin Ramesa
Variable db_maxoff is in other files declared as unsigned long. * ddb/db_print.c (db_maxoff): Use unsigned long instead of an unsigned int.
2013-12-09ddb/db_mp.c: definition of db_console() only if CONSOLE_ON_MASTERMarin Ramesa
Function db_console() is called only if CONSOLE_ON_MASTER. If it stays this way, db_console() will not compile. I don't know if it should be removed. Maybe someone will rewrite it. * ddb/db_mp.c (db_console): Definition only if CONSOLE_ON_MASTER. * ddb/db_mp.h [CONSOLE_ON_MASTER] (db_console): Add prototype.
2013-12-09ddb/db_mp.c: use boolean instead of an intMarin Ramesa
* ddb/db_mp.c (db_enter_debug): Use boolean instead of an int.
2013-12-09ddb/db_examine.c: trivial stylistic fix for consistencyMarin Ramesa
* ddb/db_examine.c: Trivial stylistic fix for consistency.
2013-12-09ddb/db_examine.c (db_examine_cmd): remove forward declarationMarin Ramesa
* ddb/db_examine.c (db_option): Remove forward declaration.
2013-12-09ddb/db_command.c (db_command): remove forward declarationMarin Ramesa
* ddb/db_command.c (db_fncall): Remove forward declaration.
2013-12-09ddb/db_command.c: use boolean valuesMarin Ramesa
* ddb/db_command.c (db_cmd_loop_done): Use boolean values.
2013-12-09ddb/db_break.c (db_find_thread_breakpoint_here): remove unnecessary castMarin Ramesa
Variable addr is already of type db_addr_t. * ddb/db_break.c (db_find_thread_breakpoint_here) (addr): Don't cast to db_addr_t.
2013-12-09ddb/db_break.c (db_add_thread_breakpoint): fix argument listMarin Ramesa
* ddb/db_break.c (db_add_thread_breakpoint): Fix argument list.
2013-12-09ddb/db_aout.c (aout_db_lookup): remove forward declarationMarin Ramesa
* ddb/db_aout.c (db_sym_parse_and_lookup): Remove forward declaration. * ddb/db_sym.h (db_sym_parse_and_lookup): Add prototype.
2013-12-09ddb/db_aout.c (aout_db_qualified_search): use DB_SYM_NULL as return valueMarin Ramesa
Function aout_db_qualified_search() returns db_sym_t. Use DB_SYM_NULL as return value instead of zero. * ddb/db_aout.c (aout_db_qualified_search): Use DB_SYM_NULL as return value.
2013-12-09ddb/db_output.c: remove forward declarationMarin Ramesa
* ddb/db_input.h (db_check_interrupt): Add prototype. * ddb/db_output.c: Include ddb/db_input.h. (db_check_interrupt): Remove forward declaration.
2013-12-08ddb/db_output.c: remove duplicate functionMarin Ramesa
Function kdbprintf() and db_printf() are the same function. Remove kdbprintf() and define kdbprintf to db_printf. * ddb/db_output.c (kdbprintf): Remove function. * ddb/db_output.h: Define kdbprintf to db_printf. (kdbprintf): Remove prototype.
2013-12-08ddb/db_output.c: remove call to nonexistent db_printf_enter()Marin Ramesa
* ddb/db_output.c [db_printf_enter] (db_printf_enter): Remove call to nonexistent function.
2013-12-08ddb/db_command.h: remove duplicate variable declarationMarin Ramesa
* ddb/db_command.h (db_recover): Remove duplicate variable declaration.
2013-12-08ddb/db_command.c: remove forward declarationMarin Ramesa
* ddb/db_command.c (db_skip_to_eol): Remove forward declaration.
2013-12-05Add missing includeSamuel Thibault
* ddb/db_variables.h: Include <machine/db_machdep.h>.
2013-12-05ddb/db_variables.c: fix near initializationMarin Ramesa
* ddb/db_task_thread.c (db_set_default_thread): New parameter. * ddb/db_task_thread.h (db_set_default_thread): Likewise.
2013-12-05ddb/db_variables.c: remove forward declarationsMarin Ramesa
* ddb/db_task_thread.h: Include ddb/db_variables.h. (db_set_default_thread, db_get_task_thread): Add prototypes. * ddb/db_variables: Include ddb/db_macro.h. (db_set_default_thread, db_get_task_thread, db_arg_variable): Remove forward declarations.
2013-12-05ddb/db_trap.c: remove forward declarationsMarin Ramesa
* ddb/db_run.h (db_restart_at_pc, db_stop_at_pc): Add prototypes. * ddb/db_trap.c (db_restart_at_pc, db_stop_at_pc): Remove forward declarations. Include ddb/db_run.h.
2013-12-05ddb/db_command.c: remove useless forward declaration without definitionMarin Ramesa
* ddb/db_command.c (ddb_display): Remove forward declaration. Remove ddb_display call.
2013-12-05ddb/db_command.c: remove forward declarationMarin Ramesa
* ddb/db_command.c (db_reset_cpu): Remove forward declaration. * i386/i386/db_interface.h (db_reset_cpu): Add prototype. * i386/i386at/model_dep.c: Include i386/db_interface.h.
2013-12-05ddb/db_sym.c: fix argument listMarin Ramesa
* ddb/db_sym.c (dummy_db_free_symbol): Fix argument list.
2013-12-05ddb/db_sym.c: remove useless forward declarations without definitionsMarin Ramesa
* ddb/db_sym.c (coff_db_sym_init, coff_db_line_at_pc, db_sym_t coff_db_lookup, coff_db_search_symbol, coff_db_symbol_values): Remove forward declarations. (x_db): Modify field definition.
2013-12-05ddb: new header file db_aout.hMarin Ramesa
* Makefrag.am: Include ddb/db_aout.h. * ddb/db_aout.c: Include ddb/db_aout.h. * ddb/db_aout.h: New file. Add copyright. [_DDB_DB_AOUT_H_]: Add ifndef. Include ddb/db_sym.h. Include machine/db_machdep.h. (aout_db_line_at_pc, aout_db_lookup, aout_db_search_symbol, aout_db_symbol_values): Add prototypes. * ddb/db_sym.c: Include ddb/db_aout.h. (db_search_in_task_symbol, aout_db_line_at_pc, aout_db_lookup, aout_db_search_symbol, aout_db_symbol_values): Remove forward declarations. * ddb/db_sym.h (db_search_in_task_symbol): Add prototype.
2013-12-05ddb/db_aout.c: trivial stylistic fix for consistencyMarin Ramesa
* ddb/db_aout.c: Trivial stylistic fix for consistency.
2013-12-05ddb/db_run.c: add comment after endifMarin Ramesa
* ddb/db_run.c [FIXUP_PC_AFTER_BREAK]: Add comment after endif.
2013-12-05ddb/db_mp.c: add comment after else and endifMarin Ramesa
* ddb/db_mp.c [CONSOLE_ON_MASTER]: Add comment after else and endif.
2013-12-05ddb/db_input.c: add comment after endifMarin Ramesa
* ddb/db_input.c [DB_HISTORY_SIZE]: Add comment after endif.
2013-12-05ddb/db_command.c: remove forward declarationsMarin Ramesa
* ddb/db_command.c: Include machine/db_interface.h. (db_help_cmd, db_stack_trace_cmd): Remove forward declarations. * ddb/db_command.h (db_help_cmd): Add prototype. * i386/i386/db_interface.h (db_stack_trace_cmd): Add prototype.
2013-11-24Modify struct db_variableMarin Ramesa
* ddb/db_macro.c (db_arg_variable): Make function void. * ddb/db_macro.h (db_arg_variable): Declare void return. * ddb/db_task_thread.c (db_set_default_thread): Make function void. (db_get_task_thread): Make function void. * ddb/db_variables.c (db_set_default_thread, db_get_task_thread, db_arg_variable): Declare void return. (db_read_write_variable): Use void in initialization. * ddb/db_variables.h (db_variable): Make third member return void. [FCN_NULL]: Define void. * i386/i386/db_trace.c (db_i386_reg_value): Make function void.
2013-11-24ddb/db_examine.c: trivial stylistic fix for consistencyMarin Ramesa
* ddb/db_examine.c: Trivial stylistic fix for consistency.
2013-11-24ddb: move forward declarations into a header fileMarin Ramesa
* ddb/db_examine.c (db_disasm, db_search): Remove forward declarations. * ddb/db_examine.h (db_disasm, db_search): Add prototypes.
2013-11-24ddb: move forward declaration into a header fileMarin Ramesa
* ddb/db_sym.c (db_lookup): Remove forward declaration. * ddb/db_sym.h (db_lookup): Add prototype.
2013-11-24ddb: create new header file db_mp.hMarin Ramesa
* Makefrag.am: Include ddb/db_mp.h. * ddb/db_mp.c (remote_db, lock_db, unlock_db): Remove forward declarations. * ddb/db_mp.h: New file. Add copyright. [_DDB_DB_MP_H_]: Add ifndef. (remote_db, lock_db, unlock_db): Add prototypes.
2013-11-24ddb: move forward declarations into a header fileMarin Ramesa
* ddb/db_run.c (db_set_task_single_step, db_clear_task_single_step): Remove forward declarations. * ddb/db_run.h (db_set_task_single_step, db_clear_task_single_step): Add prototypes.
2013-11-24Simplify testSamuel Thibault
* ddb/db_sym.c (db_name_is_ambiguous): Simplify test for value returned by X_db_lookup.
2013-11-24Remove leftover register qualifiersMarin Ramesa
* ddb/db_break.c: Remove register qualifiers. * i386/i386/pcb.c: Likewise. * i386/i386at/com.c: Likewise. * i386/i386at/lpr.c: Likewise. * i386/intel/pmap.c: Likewise. * kern/machine.c: Likewise. * kern/queue.h: Likewise. * kern/sched_prim.c: Likewise. * kern/sched_prim.h: Likewise. * kern/timer.c: Likewise. * vm/vm_fault.c: Likewise. * vm/vm_resident.h: Likewise.
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-28 04:01:05 +0000