Age | Commit message (Collapse) | Author |
|
|
|
Initialize lhs to zero to avoid uninitialized usage in db_unary().
* ddb/db_expr.c (db_mult_expr) (lhs): Initialize to zero.
|
|
Now that we have returns there are no more warnings from GCC about
uninitialized variable. Remove unnecessary initialization of variable
bkpt.
* ddb/db_break.c (db_delete_cmd) (bkpt): Remove unnecessary initialization.
|
|
Variable addr and member address are already of db_addr_t type which
is type defined as vm_offset_t.
* ddb/db_break.c (db_find_breakpoint_here) (DB_PHYS_EQ) (addr, address): Remove unecessary casts.
|
|
|
|
* ddb/db_break.h (db_check_breakpoint_valid): Add prototype.
* ddb/db_trap.c (db_init_default_thread, db_check_breakpoint_valid): Remove forward declarations.
|
|
In this way everything falls into place and there is one cast less.
Function db_task_printsym() is already always called with the cast to
db_addr_t in the first argument.
* ddb/db_aout.c (aout_db_line_at_pc): Use db_addr_t instead of db_expr_t.
(aout_db_search_by_addr): Don't cast to vm_offset_t. Argument is already
db_addr_t.
* ddb/db_aout.h (aout_db_line_at_pc): Use db_addr_t instead of db_expr_t.
* ddb/db_sym.c (db_task_printsym): Likewise.
(db_line_at_pc): Likewise.
* ddb/db_sym.h (db_task_printsym): Likewise.
(db_line_at_pc): Likewise.
* i386/i386/db_trace.c (db_task_printsym): Cast to db_addr_t instead of db_expr_t.
Member swap_func is a pointer to void.
|
|
Variable db_maxoff is in other files declared as unsigned long.
* ddb/db_print.c (db_maxoff): Use unsigned long instead of an unsigned int.
|
|
Function db_console() is called only if CONSOLE_ON_MASTER.
If it stays this way, db_console() will not compile. I don't know
if it should be removed. Maybe someone will rewrite it.
* ddb/db_mp.c (db_console): Definition only if CONSOLE_ON_MASTER.
* ddb/db_mp.h [CONSOLE_ON_MASTER] (db_console): Add prototype.
|
|
* ddb/db_mp.c (db_enter_debug): Use boolean instead of an int.
|
|
* ddb/db_examine.c: Trivial stylistic fix for consistency.
|
|
* ddb/db_examine.c (db_option): Remove forward declaration.
|
|
* ddb/db_command.c (db_fncall): Remove forward declaration.
|
|
* ddb/db_command.c (db_cmd_loop_done): Use boolean values.
|
|
Variable addr is already of type db_addr_t.
* ddb/db_break.c (db_find_thread_breakpoint_here) (addr): Don't cast to db_addr_t.
|
|
* ddb/db_break.c (db_add_thread_breakpoint): Fix argument list.
|
|
* ddb/db_aout.c (db_sym_parse_and_lookup): Remove forward declaration.
* ddb/db_sym.h (db_sym_parse_and_lookup): Add prototype.
|
|
Function aout_db_qualified_search() returns db_sym_t. Use DB_SYM_NULL as
return value instead of zero.
* ddb/db_aout.c (aout_db_qualified_search): Use DB_SYM_NULL as return value.
|
|
* ddb/db_input.h (db_check_interrupt): Add prototype.
* ddb/db_output.c: Include ddb/db_input.h.
(db_check_interrupt): Remove forward declaration.
|
|
Function kdbprintf() and db_printf() are the same function. Remove
kdbprintf() and define kdbprintf to db_printf.
* ddb/db_output.c (kdbprintf): Remove function.
* ddb/db_output.h: Define kdbprintf to db_printf.
(kdbprintf): Remove prototype.
|
|
* ddb/db_output.c [db_printf_enter] (db_printf_enter): Remove call to nonexistent function.
|
|
* ddb/db_command.h (db_recover): Remove duplicate variable declaration.
|
|
* ddb/db_command.c (db_skip_to_eol): Remove forward declaration.
|
|
* ddb/db_variables.h: Include <machine/db_machdep.h>.
|
|
* ddb/db_task_thread.c (db_set_default_thread): New parameter.
* ddb/db_task_thread.h (db_set_default_thread): Likewise.
|
|
* ddb/db_task_thread.h: Include ddb/db_variables.h.
(db_set_default_thread, db_get_task_thread): Add prototypes.
* ddb/db_variables: Include ddb/db_macro.h.
(db_set_default_thread, db_get_task_thread, db_arg_variable): Remove forward declarations.
|
|
* ddb/db_run.h (db_restart_at_pc, db_stop_at_pc): Add prototypes.
* ddb/db_trap.c (db_restart_at_pc, db_stop_at_pc): Remove forward declarations.
Include ddb/db_run.h.
|
|
* ddb/db_command.c (ddb_display): Remove forward declaration.
Remove ddb_display call.
|
|
* ddb/db_command.c (db_reset_cpu): Remove forward declaration.
* i386/i386/db_interface.h (db_reset_cpu): Add prototype.
* i386/i386at/model_dep.c: Include i386/db_interface.h.
|
|
* ddb/db_sym.c (dummy_db_free_symbol): Fix argument list.
|
|
* ddb/db_sym.c (coff_db_sym_init, coff_db_line_at_pc, db_sym_t coff_db_lookup, coff_db_search_symbol, coff_db_symbol_values): Remove forward declarations.
(x_db): Modify field definition.
|
|
* Makefrag.am: Include ddb/db_aout.h.
* ddb/db_aout.c: Include ddb/db_aout.h.
* ddb/db_aout.h: New file.
Add copyright.
[_DDB_DB_AOUT_H_]: Add ifndef.
Include ddb/db_sym.h.
Include machine/db_machdep.h.
(aout_db_line_at_pc, aout_db_lookup, aout_db_search_symbol, aout_db_symbol_values): Add prototypes.
* ddb/db_sym.c: Include ddb/db_aout.h.
(db_search_in_task_symbol, aout_db_line_at_pc, aout_db_lookup, aout_db_search_symbol, aout_db_symbol_values): Remove forward declarations.
* ddb/db_sym.h (db_search_in_task_symbol): Add prototype.
|
|
* ddb/db_aout.c: Trivial stylistic fix for consistency.
|
|
* ddb/db_run.c [FIXUP_PC_AFTER_BREAK]: Add comment after endif.
|
|
* ddb/db_mp.c [CONSOLE_ON_MASTER]: Add comment after else and endif.
|
|
* ddb/db_input.c [DB_HISTORY_SIZE]: Add comment after endif.
|
|
* ddb/db_command.c: Include machine/db_interface.h.
(db_help_cmd, db_stack_trace_cmd): Remove forward declarations.
* ddb/db_command.h (db_help_cmd): Add prototype.
* i386/i386/db_interface.h (db_stack_trace_cmd): Add prototype.
|
|
* ddb/db_macro.c (db_arg_variable): Make function void.
* ddb/db_macro.h (db_arg_variable): Declare void return.
* ddb/db_task_thread.c (db_set_default_thread): Make function void.
(db_get_task_thread): Make function void.
* ddb/db_variables.c (db_set_default_thread, db_get_task_thread, db_arg_variable): Declare void return.
(db_read_write_variable): Use void in initialization.
* ddb/db_variables.h (db_variable): Make third member return void.
[FCN_NULL]: Define void.
* i386/i386/db_trace.c (db_i386_reg_value): Make function void.
|
|
* ddb/db_examine.c: Trivial stylistic fix for consistency.
|
|
* ddb/db_examine.c (db_disasm, db_search): Remove forward declarations.
* ddb/db_examine.h (db_disasm, db_search): Add prototypes.
|
|
* ddb/db_sym.c (db_lookup): Remove forward declaration.
* ddb/db_sym.h (db_lookup): Add prototype.
|
|
* Makefrag.am: Include ddb/db_mp.h.
* ddb/db_mp.c (remote_db, lock_db, unlock_db): Remove forward declarations.
* ddb/db_mp.h: New file.
Add copyright.
[_DDB_DB_MP_H_]: Add ifndef.
(remote_db, lock_db, unlock_db): Add prototypes.
|
|
* ddb/db_run.c (db_set_task_single_step, db_clear_task_single_step): Remove forward declarations.
* ddb/db_run.h (db_set_task_single_step, db_clear_task_single_step): Add prototypes.
|
|
* ddb/db_sym.c (db_name_is_ambiguous): Simplify test for value returned by
X_db_lookup.
|
|
* ddb/db_break.c: Remove register qualifiers.
* i386/i386/pcb.c: Likewise.
* i386/i386at/com.c: Likewise.
* i386/i386at/lpr.c: Likewise.
* i386/intel/pmap.c: Likewise.
* kern/machine.c: Likewise.
* kern/queue.h: Likewise.
* kern/sched_prim.c: Likewise.
* kern/sched_prim.h: Likewise.
* kern/timer.c: Likewise.
* vm/vm_fault.c: Likewise.
* vm/vm_resident.h: Likewise.
|
|
* ddb/db_break.c: Don't include ddb/db_access.h.
|
|
* ddb/db_sym.c: Move assignment outside of if.
(db_lookup): New variable.
|
|
* ddb/db_break.c: Include machine/db_interface.h.
|
|
* ddb/db_sym.c (aout_db_sym_init): Remove forward declaration.
* ddb/db_sym.h (aout_db_sym_init): Add prototype.
* i386/i386at/model_dep.c (aout_db_sym_init): Fix call.
[MACH_KDB]: Include ddb/db_sym.h.
[MACH_KDB]: Add comment after else and endif.
|
|
* ddb/db_variables.c (db_set_default_thread, db_get_task_thread, db_arg_variable, fcn): Declare long return type.
|