summaryrefslogtreecommitdiff
path: root/linux/src/drivers/scsi/FlashPoint.c
diff options
context:
space:
mode:
authorJustus Winter <4winter@informatik.uni-hamburg.de>2014-01-05 14:11:29 +0100
committerJustus Winter <4winter@informatik.uni-hamburg.de>2014-01-05 14:11:29 +0100
commit5faed5128d3c07f055f96d910529c95814073a09 (patch)
tree541b83a4f99fcc70ec73b1e313d052233a515390 /linux/src/drivers/scsi/FlashPoint.c
parent8982de2eb4fa2fa6f5a350c348c211542aecfaa1 (diff)
linux: fix bit tests
The pattern is !x&y. An expression of this form is almost always meaningless, because it combines a boolean operator with a bit operator. In particular, if the rightmost bit of y is 0, the result will always be 0. Fixed using coccinelle. // !x&y combines boolean negation with bitwise and // // Confidence: High // Copyright: (C) Gilles Muller, Julia Lawall, EMN, DIKU. GPLv2. // URL: http://www.emn.fr/x-info/coccinelle/rules/notand.html // Options: @@ expression E; constant C; @@ ( !E & !C | - !E & C + !(E & C) ) * linux/src/drivers/net/tlan.c: Fix bit tests. * linux/src/drivers/scsi/AM53C974.c: Likewise. * linux/src/drivers/scsi/FlashPoint.c: Likewise. * linux/src/drivers/scsi/NCR5380.c: Likewise. * linux/src/drivers/scsi/t128.c: Likewise.
Diffstat (limited to 'linux/src/drivers/scsi/FlashPoint.c')
-rw-r--r--linux/src/drivers/scsi/FlashPoint.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/linux/src/drivers/scsi/FlashPoint.c b/linux/src/drivers/scsi/FlashPoint.c
index aae35c0..4b96a66 100644
--- a/linux/src/drivers/scsi/FlashPoint.c
+++ b/linux/src/drivers/scsi/FlashPoint.c
@@ -3845,7 +3845,7 @@ int SetDevWideMode(PSCCBcard pCurrCard,PUCB p_ucb)
}
else
{
- if(!currTar_Info->TarEEValue & EE_WIDE_SCSI)
+ if(!(currTar_Info->TarEEValue & EE_WIDE_SCSI))
{
return(0);
}