diff options
| author | Justus Winter <4winter@informatik.uni-hamburg.de> | 2014-01-05 14:11:29 +0100 |
|---|---|---|
| committer | Justus Winter <4winter@informatik.uni-hamburg.de> | 2014-01-05 14:11:29 +0100 |
| commit | 5faed5128d3c07f055f96d910529c95814073a09 (patch) | |
| tree | 541b83a4f99fcc70ec73b1e313d052233a515390 /device/dev_lookup.c | |
| parent | 8982de2eb4fa2fa6f5a350c348c211542aecfaa1 (diff) | |
linux: fix bit tests
The pattern is !x&y. An expression of this form is almost always
meaningless, because it combines a boolean operator with a bit
operator. In particular, if the rightmost bit of y is 0, the result
will always be 0.
Fixed using coccinelle.
// !x&y combines boolean negation with bitwise and
//
// Confidence: High
// Copyright: (C) Gilles Muller, Julia Lawall, EMN, DIKU. GPLv2.
// URL: http://www.emn.fr/x-info/coccinelle/rules/notand.html
// Options:
@@ expression E; constant C; @@
(
!E & !C
|
- !E & C
+ !(E & C)
)
* linux/src/drivers/net/tlan.c: Fix bit tests.
* linux/src/drivers/scsi/AM53C974.c: Likewise.
* linux/src/drivers/scsi/FlashPoint.c: Likewise.
* linux/src/drivers/scsi/NCR5380.c: Likewise.
* linux/src/drivers/scsi/t128.c: Likewise.
Diffstat (limited to 'device/dev_lookup.c')
0 files changed, 0 insertions, 0 deletions