From 49a086299e047b18280457b654790ef4a2e5abfa Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Wed, 18 Feb 2015 00:58:35 +0100 Subject: Revert "rename open_issues.mdwn to service_solahart_jakarta_selatan__082122541663.mdwn" This reverts commit 95878586ec7611791f4001a4ee17abf943fae3c1. --- open_issues/gnumach_integer_overflow.mdwn | 50 +++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 open_issues/gnumach_integer_overflow.mdwn (limited to 'open_issues/gnumach_integer_overflow.mdwn') diff --git a/open_issues/gnumach_integer_overflow.mdwn b/open_issues/gnumach_integer_overflow.mdwn new file mode 100644 index 00000000..08a29268 --- /dev/null +++ b/open_issues/gnumach_integer_overflow.mdwn @@ -0,0 +1,50 @@ +[[!meta copyright="Copyright © 2012, 2013 Free Software Foundation, Inc."]] + +[[!meta license="""[[!toggle id="license" text="GFDL 1.2+"]][[!toggleable +id="license" text="Permission is granted to copy, distribute and/or modify this +document under the terms of the GNU Free Documentation License, Version 1.2 or +any later version published by the Free Software Foundation; with no Invariant +Sections, no Front-Cover Texts, and no Back-Cover Texts. A copy of the license +is included in the section entitled [[GNU Free Documentation +License|/fdl]]."]]"""]] + +[[!tag open_issue_gnumach]] + + +# IRC, freenode, #hurd, 2012-07-04 + + yes, we have integer overflows on resident_page_count, but + luckily, the member is rarely used + +See also [[gnumach_vm_object_resident_page_count]]. + + +## IRC, freenode, #hurd, 2013-06-04 + + this is declared as int on vm_object.h + and as it as counter it's always positive + yes it should be unsigned + ok + but leave it as it is for consistency with the rest + i send patch :) + please no + unless you've fully determined the side effects + i've grepped the vars and saw only comparisons > and = 0 + never less than 0 + > 0 is the same + well + > not, but >= would be a problem + http://paste.debian.net/plain/8527 + asctually no >=0 + still, i don't want to change that unless it's strictly necessary + hum, you're grepping ref_count, not resident_page_count + i did both + on resident_page_count theres resident_page_count >= 0 + = 0, == 0 + this isn't the only possible issue + anyway + for now there is no reason to change anything unless you do a full + review + only place i see resdent_page_count and page_count being decreased + it's on vm/vm_resident.c + vm_page_remove() and vm_page_replace() -- cgit v1.2.3