From 43978367bcd5f1121c5ade31b80de66aaa511ca8 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Thu, 4 Oct 2012 01:17:55 +0200 Subject: Remove, old issue fixed recently. --- open_issues/glibc/getlogin_r.mdwn | 45 --------------------------------------- 1 file changed, 45 deletions(-) delete mode 100644 open_issues/glibc/getlogin_r.mdwn (limited to 'open_issues/glibc') diff --git a/open_issues/glibc/getlogin_r.mdwn b/open_issues/glibc/getlogin_r.mdwn deleted file mode 100644 index 9980ea1f..00000000 --- a/open_issues/glibc/getlogin_r.mdwn +++ /dev/null @@ -1,45 +0,0 @@ -[[!meta copyright="Copyright © 2012 Free Software Foundation, Inc."]] - -[[!meta license="""[[!toggle id="license" text="GFDL 1.2+"]][[!toggleable -id="license" text="Permission is granted to copy, distribute and/or modify this -document under the terms of the GNU Free Documentation License, Version 1.2 or -any later version published by the Free Software Foundation; with no Invariant -Sections, no Front-Cover Texts, and no Back-Cover Texts. A copy of the license -is included in the section entitled [[GNU Free Documentation -License|/fdl]]."]]"""]] - -[[!meta title="getlogin_r"]] - -[[!tag open_issue_glibc]] - - -# IRC, freenode, #hurd, 2012-04-23 - - * pinotree spots how our getlogin_r() implementation uses a static - buffer... - oO - braunr: yeah, the _r means "reentrantbutnotreally" xD - pinotree: that's amazing .. - pinotree: without having checked the actual implementation, that - doesn't sound like a problem... - caching doesn't break reentrancy. the problem with the plain - getlogin() is that a static buffer is *returned to the user* - antrik: http://paste.debian.net/164727/ - ah, caching - i don't think this is caching at all - pinotree: OK, not actually caching... but same effect as far as I - can tell - pinotree: or is it the fixed size of the temporary variable you - are concerned about? - antrik: my concern was about the "static" of the buffer used for - the get_login rpc - pinotree: I'm not sure that's a problem. can the login actually - ever change for a running process? - dunno - but if so, it would be pointless to do the rpc every time - instead of just once - pinotree: true - * pinotree would just make it non-static and be safe - pinotree: well, one might argue that allocating a KiB of stack - space is not very friendly, especially in a low-level library... - not sure what the general policy is about such things in libc -- cgit v1.2.3