From eccdd13dd3c812b8f0b3d046ef9d8738df00562a Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 25 Sep 2013 21:45:38 +0200 Subject: IRC. --- hurd/running/debian/dhcp.mdwn | 97 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 96 insertions(+), 1 deletion(-) (limited to 'hurd/running/debian') diff --git a/hurd/running/debian/dhcp.mdwn b/hurd/running/debian/dhcp.mdwn index afa46799..849ff382 100644 --- a/hurd/running/debian/dhcp.mdwn +++ b/hurd/running/debian/dhcp.mdwn @@ -1,4 +1,5 @@ -[[!meta copyright="Copyright © 2011, 2012 Free Software Foundation, Inc."]] +[[!meta copyright="Copyright © 2011, 2012, 2013 Free Software Foundation, +Inc."]] [[!meta license="""[[!toggle id="license" text="GFDL 1.2+"]][[!toggleable id="license" text="Permission is granted to copy, distribute and/or modify this @@ -29,3 +30,97 @@ scripts, but has its own `/libexec/rc` script -- which integrates scripts from * [[!debbug 616290]] * [[Proper Hurdy DHCP support|hurd/translator/pfinet/dhcp]] + + * [[!message-id desc="dhclient aborting with a stack smashing error" + "874ngfvwn4.fsf@kepler.schwinge.homeip.net"]] + + IRC, freenode, #hurd, 2013-08-21: + + yay, I fixed the path of the dhcp leases file... + ... and now dhclient dies of a buffer overflow + fortunately the fix is rather simple, anyone who cares about + the security of his box just has to stop using isc software + the code is full of stuff like char foo[100]; /* surely + that's enough */ + note that our version of isc-dchp (the one in ports) is + older than the latest one available in unstable (which is still older + than the latest upstream releases) + so? + dunno, might have been fixed or not + ^^ yeah sure + A lot of software has these limitations and PATH_MAX, + MAXPATHLEN issues :( + having a limitation is not a problem per-se + no, only software written in c has these kind of problems + the problem is not checking whether the limits are hit + well, looking at the source of isc-dhcp my time is better + spent making another dhcp client work on hurd + also reading up on bug #616290 does make me want to avoid + touching it ever + hehe + teythoon: somebody was offering an alternative to the isc + dhcpclient, but I think it was rejected by Samuel? + why would he do that? + probably for compliance + He probably thought they would release a new version soon, is + 4.3.0 out yet? + well, as soon as my fixes for ifupdown go in, dhclient will + start crashing + no, there is no new version released + no major one that is + 4.2.5 is out + can't you just increase the buffer size, where is the problem + exactly? + I have no idea + The Hurd patches are not in 4.2.5, they were promised for + 4.3.0a1. + Still the buffer overflow problem might be present in 4.2.5 + if patched to build on Hurd. + there, darnassus now has a fully featured git/gitweb service + :) + btw, I managed to reproduce the crash reliably + rm /var/lib/dhcp/*; dhclient -v /dev/eth0 ... *boom* + ditch the -v, everything works, and now that there is a + lease file, you can add the -v again and it works + ew :) + and what has dhclient.c to say for its defense? + log_info("%s", ""); + hm, not much :/ + + IRC, freenode, #hurd, 2013-08-22: + + uh, the isc-dhcp situation is a huge pita, the source on + -ports does not compile anymore :/ + + IRC, freenode, #hurd, 2013-08-23: + + teythoon: Was it the slash in the network interface names + that caused the buffer overflow in dhclient? + gnu_srs: no, previously no dhcp leases file was written and + everything was fine + teythoon: did you really develop your patch against that old + version of ifupdown? + gnu_srs: now it is written, and for some reason dhclient + crashes *iff* -v is given *and* there is no previous lease file + pinotree: no, I did not. that was only reportbug including + information from my desktop machine without asking me + but when I first looked at ifupdown it was still a 6000 + lines noweb file >,< + that was fun + which version is it against? + hg tip + + IRC, freenode, #hurd, 2013-08-30: + + teythoon: I understand correctly that you found that + id:"874ngfvwn4.fsf@kepler.schwinge.homeip.net" in fact was really + "just" a buffer overflow in the dhclient code? + tschwinge: ah, most interesting, I didn't realize that you + stumbled across this as well + to be honest I don't know what's going on there, I only + observed what I wrote in my report + for me it started crashing once the lease file was actually + a valid path (i.e. not to a non-existing directory b/c of the slashes + in /dev/eth0) + I tried to rebuild the package served on debian-ports, but + that failed -- cgit v1.2.3