From e3762c2224c6dcc34db554dd489eb39e21a078e9 Mon Sep 17 00:00:00 2001 From: "https://www.google.com/accounts/o8/id?id=AItOawkapgJmI1MqlCs1DFe8MqLs3z_F7u-2n34" Date: Mon, 7 Oct 2013 22:43:08 +0200 Subject: Fix link --- open_issues/glibc.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/open_issues/glibc.mdwn b/open_issues/glibc.mdwn index b453b44f..8fac2c1e 100644 --- a/open_issues/glibc.mdwn +++ b/open_issues/glibc.mdwn @@ -22,7 +22,7 @@ Here's what's to be done for maintaining glibc. # [[Sources|source_repositories/glibc]] -# [[Debian]] Cheat Sheet +# [[Debian Cheat Sheet|debian]] # Configuration -- cgit v1.2.3 From 36744577a3056da6251498e38ec2c0b7e6b6a9ba Mon Sep 17 00:00:00 2001 From: "https://www.google.com/accounts/o8/id?id=AItOawkapgJmI1MqlCs1DFe8MqLs3z_F7u-2n34" Date: Tue, 8 Oct 2013 01:04:10 +0200 Subject: Add anchors to openissues/glibc. --- open_issues/glibc.mdwn | 112 ++++++++++++++++++++++++------------------------- 1 file changed, 56 insertions(+), 56 deletions(-) diff --git a/open_issues/glibc.mdwn b/open_issues/glibc.mdwn index 8fac2c1e..0c702144 100644 --- a/open_issues/glibc.mdwn +++ b/open_issues/glibc.mdwn @@ -39,24 +39,24 @@ git log --reverse --topo-order --pretty=fuller --stat=$COLUMNS,$COLUMNS -w -p -C Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 (2013-05-24) sources|source_repositories/glibc]]. - * `t/hurdsig-fixes` + * `t/hurdsig-fixes` hurdsig.c: In function '_hurd_internal_post_signal': hurdsig.c:1188:26: warning: 'pending' may be used uninitialized in this function [-Wmaybe-uninitialized] hurdsig.c:1168:12: note: 'pending' was declared here - * `t/host-independency` + * `t/host-independency` [[!message-id "87bougerfb.fsf@kepler.schwinge.homeip.net"]], [[!message-id "20120525202732.GA31088@intel.com"]], commit 918b56067a444572f1c71b02f18255ae4540b043. [[!GCC_PR 53183]], GCC commit c05436a7e361b8040ee899266e15bea817212c37. - * `t/pie-sbrk` + * `t/pie-sbrk` [[gcc/PIE]]. - * `t/sysvshm` + * `t/sysvshm` ../sysdeps/mach/hurd/shmat.c: In function '__shmat': ../sysdeps/mach/hurd/shmat.c:57:7: warning: implicit declaration of function '__close' [-Wimplicit-function-declaration] @@ -65,11 +65,11 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 ../sysdeps/mach/hurd/shmget.c:102:8: warning: 'dir' may be used uninitialized in this function [-Wmaybe-uninitialized] ../sysdeps/mach/hurd/shmget.c:102:8: warning: 'file' may be used uninitialized in this function [-Wmaybe-uninitialized] - * [[`t/tls`|t/tls]] + * [[`t/tls`|t/tls]] - * [[`t/tls-threadvar`|t/tls-threadvar]] + * [[`t/tls-threadvar`|t/tls-threadvar]] - * t/verify.h + * `t/verify.h` People didn't like this too much. @@ -77,7 +77,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 * 11988f8f9656042c3dfd9002ac85dff33173b9bd -- `static_assert` - * [[toolchain/cross-gnu]], without `--disable-multi-arch` + * [[toolchain/cross-gnu]], without `--disable-multi-arch` i686-pc-gnu-gcc ../sysdeps/i386/i686/multiarch/strcmp.S -c [...] ../sysdeps/i386/i686/multiarch/../strcmp.S: Assembler messages: @@ -87,7 +87,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 Might simply be a missing patch(es) from master. - * `--disable-multi-arch` + * `--disable-multi-arch` IRC, freenode, #hurd, 2012-11-22 @@ -116,12 +116,12 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 Ah, I probably have been thinking about open_issues/ifunc and open_issues/libc_variant_selection. - * --build=X + * --build=X `long double` test: due to `cross_compiling = maybe` wants to execute a file, which fails. Thus `--build=X` has to be set. - * Check what all these are: + * Check what all these are: running configure fragment for sysdeps/mach/hurd checking Hurd header version... ok @@ -157,19 +157,19 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 checking for i386_set_gdt in mach_i386.defs... yes checking whether i586-pc-gnu-mig supports the retcode keyword... yes - * `sysdeps/i386/stackguard-macros.h` + * `sysdeps/i386/stackguard-macros.h` See [[t/tls|t/tls]]. - * Verify 77c84aeb81808c3109665949448dba59965c391e against - `~/shared/glibc/make_TAGS.patch`. + * Verify 77c84aeb81808c3109665949448dba59965c391e against + `~/shared/glibc/make_TAGS.patch`. - * `HP_SMALL_TIMING_AVAIL` not defined anywhere. + * `HP_SMALL_TIMING_AVAIL` not defined anywhere. - * Unify `CPUCLOCK_WHICH` stuff in `clock_*` files. + * Unify `CPUCLOCK_WHICH` stuff in `clock_*` files. - * Not all tests are re-run in a `make -k tests; make tests-clean; make -k - tests` cycle. For example, after `make tests-clean`: + * Not all tests are re-run in a `make -k tests; make tests-clean; make -k + tests` cycle. For example, after `make tests-clean`: $ find ./ -name \*.out ./localedata/tst-locale.out @@ -196,7 +196,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 ./check-local-headers.out ./begin-end-check.out - * `CPUCLOCK_WHICH`, `t/cpuclock` + * `CPUCLOCK_WHICH`, `t/cpuclock` /media/boole-data/thomas/tmp/gnu-0/src/glibc.obj/rt/librt_pic.a(clock_settime.os): In function `clock_settime': /media/boole-data/thomas/tmp/gnu-0/src/glibc/rt/../sysdeps/unix/clock_settime.c:113: undefined reference to `CPUCLOCK_WHICH' @@ -208,7 +208,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 make[1]: Leaving directory `/media/boole-data/thomas/tmp/gnu-0/src/glibc' make: *** [all] Error 2 - * Missing interfaces, amongst many more. + * Missing interfaces, amongst many more. Many more are missing, some of which have been announced in `NEWS`, others typically haven't (like new flags to existing functions). Typically, @@ -228,7 +228,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 Check also the content of `gnu/stubs.h`, which lists all the functions marked as stub which only return `ENOSYS`. - * `chflags` + * `chflags` Patch sent, [[!message-id "20120427012130.GZ19431@type.famille.thibault.fr"]]. @@ -259,25 +259,25 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 so I'd say ignore the error for now, we'll add the declaration - * [[t/tls-threadvar]] + * [[t/tls-threadvar]] - * `futimesat` + * `futimesat` If we have all of 'em (check Linux kernel), `#define __ASSUME_ATFCTS`. - * `bits/stat.h [__USE_ATFILE]`: `UTIME_NOW`, `UTIME_OMIT` + * `bits/stat.h [__USE_ATFILE]`: `UTIME_NOW`, `UTIME_OMIT` - * `io/fcntl.h [__USE_ATFILE]` + * `io/fcntl.h [__USE_ATFILE]` Do we support `AT_FDCWD` et al.? (80b4e5f3ef231702b24d44c33e8dceb70abb3a06.) - * `t/opendirat`: `opendirat` (`scandirat`, `scandirat64`) + * `t/opendirat`: `opendirat` (`scandirat`, `scandirat64`) Need changes equivalent to c55fbd1ea768f9fdef34a01377702c0d72cbc213 + 14d96785125abee5e9a49a1c3037f35a581750bd. - * `madvise`, `MADV_DONTNEED`, `MADV_DONTDUMP`, `MADV_DODUMP` + * `madvise`, `MADV_DONTNEED`, `MADV_DONTDUMP`, `MADV_DODUMP` [[glibc_madvise_vs_static_linking]]. @@ -303,11 +303,11 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 [...] - Disable jemalloc on hurd and kfreebsd-*. No longer disabled upstream. - * `msync` + * `msync` Then define `_POSIX_MAPPED_FILES`, `_POSIX_SYNCHRONIZED_IO`. - * `epoll`, `sys/epoll.h` + * `epoll`, `sys/epoll.h` Used by [[wayland]], for example. @@ -330,18 +330,18 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 clearly not a priority ok - * `sys/eventfd.h` + * `sys/eventfd.h` - * `sys/inotify.h` + * `sys/inotify.h` - * `sys/signalfd.h` + * `sys/signalfd.h` - * `sys/timerfd.h` + * `sys/timerfd.h` - * `timespec_get` (74033a2507841cf077e31221de2481ff30b43d51, - 87f51853ce3671f4ba9a9953de1fff952c5f7e52) + * `timespec_get` (74033a2507841cf077e31221de2481ff30b43d51, + 87f51853ce3671f4ba9a9953de1fff952c5f7e52) - * `waitflags.h` (`WEXITED`, `WNOWAIT`, `WSTOPPED`, `WCONTINUED`) + * `waitflags.h` (`WEXITED`, `WNOWAIT`, `WSTOPPED`, `WCONTINUED`) IRC, freenode, #hurd, 2012-04-20: @@ -368,9 +368,9 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 See `posix/tst-waitid.out` failure below. - * `getconf` things (see below the results of `tst-getconf.out`) + * `getconf` things (see below the results of `tst-getconf.out`) - * `getsockopt`, `setsockopt` + * `getsockopt`, `setsockopt` IRC, freenode, #hurd, 2013-02-14 @@ -415,7 +415,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 no, linux is more permissive (at least, on this matter) - * `getcontext`/`makecontext`/`setcontext`/`swapcontext` + * `getcontext`/`makecontext`/`setcontext`/`swapcontext` Support for these functions within the Hurd threadvar environment has been added, but for multi-threaded applications ([[libpthread]]), it is @@ -854,7 +854,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 to check where those locks are held and determine the right order - * `recvmmsg`/`sendmmsg` (`t/sendmmsg`) + * `recvmmsg`/`sendmmsg` (`t/sendmmsg`) From [[!message-id "20120625233206.C000A2C06F@topped-with-meat.com"]], Roland McGrath: *They are generally useful interfaces and there is @@ -865,7 +865,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 Then perhaps the Linux fallback case should be that instead of stubs, too.* - * `SOCK_CLOEXEC` + * `SOCK_CLOEXEC` IRC, freenode, #hurd, 2013-09-02: @@ -994,19 +994,19 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 For specific packages: - * [[octave]] + * [[octave]] - * Create `t/cleanup_kernel-features.h`. + * Create `t/cleanup_kernel-features.h`. - * [[Secure_file_descriptor_handling]]. + * [[Secure_file_descriptor_handling]]. - * In `sysdeps/unix/sysv/linux/Makefile`, there are a bunch of - `-DHAVE_SENDFILE` -- but we do have `sendfile`, too. + * In `sysdeps/unix/sysv/linux/Makefile`, there are a bunch of + `-DHAVE_SENDFILE` -- but we do have `sendfile`, too. Define `__ASSUME_SENDFILE` to 1 in `kernel-features.h`, if `sendfile` works. - * `/usr/include/pthread.h` overwrite issue + * `/usr/include/pthread.h` overwrite issue `make`, after editing `nss/nss_db/db-initgroups.c`: @@ -1027,9 +1027,9 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 install`, prepending an additional slash to `install_root` (that is, `install_root=//[...]`) is enough to obfuscate the Makefile rules. - * `sysdeps/unix/sysv/linux/syslog.c` + * `sysdeps/unix/sysv/linux/syslog.c` - * `fsync` on a pipe + * `fsync` on a pipe IRC, freenode, #hurd, 2012-08-21: @@ -1203,7 +1203,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 [[!message-id "1351231423.8019.19.camel@hp.my.own.domain"]]. - * `t/no-hp-timing` + * `t/no-hp-timing` IRC, freenode, #hurd, 2012-11-16 @@ -1211,7 +1211,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 couldn't that file be just replaced by #include ? - * `flockfile`/`ftrylockfile`/`funlockfile` + * `flockfile`/`ftrylockfile`/`funlockfile` IRC, freenode, #hurd, 2012-11-16 @@ -1350,7 +1350,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 provides a EXEC_PAGESIZE define in libio, so it makes it use mmap (like on linux) instead of malloc - `t/pagesize`. + * `t/pagesize`. yes, the stub is used instead of the libpthreads code tschwinge: ^ @@ -1468,7 +1468,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 ok, so all god +o - * `t/pagesize` + * `t/pagesize` IRC, freenode, #hurd, 2012-11-16 @@ -1509,7 +1509,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 size well they have to - * `LD_DEBUG` + * `LD_DEBUG` IRC, freenode, #hurd, 2012-11-22 @@ -1523,7 +1523,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 http://paste.debian.net/25934/ ← _hurd_thread_sigstate calls malloc, boom - * `conformtest` + * `conformtest` IRC, OFTC, #debian-hurd, 2013-09-22: @@ -1543,7 +1543,7 @@ Last reviewed up to the [[Git mirror's 0323d08657f111267efa47bd448fbf6cd76befe8 type for some flock structure field) s/by/be/ - * Verify baseline changes, if we need any follow-up changes: + * Verify baseline changes, if we need any follow-up changes: * a11ec63713ea3903c482dc907a108be404191a02 * 7e2b0c8562b35155820f87b5ff02a8b6850344cc -- cgit v1.2.3 From fb7b2f3ee26cb69f6f5ed332d46a09baa496c682 Mon Sep 17 00:00:00 2001 From: teythoon Date: Tue, 22 Oct 2013 17:37:57 +0200 Subject: Add small hack entry about moving the mount/umount logic to libshouldbeinlibc. --- contributing.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing.mdwn b/contributing.mdwn index 5978d01f..db2d77c6 100644 --- a/contributing.mdwn +++ b/contributing.mdwn @@ -111,7 +111,7 @@ basic port could be small. * Use libz and libbz2 in libstore. See `hurd/libstore/unzip.c` etc., they should be replaced by mere calls to libraries, [[!GNU_Savannah_task 6990]] See also the discussions on [[open_issues/exec]]. * Add `/proc/$pid/maps`. `vminfo` already has this kind of information, it's a matter of making procfs do the same. [[!GNU_Savannah_bug 32770]] - +* Move the mount/umount logic from utils/{,u}mount.c into libshouldbeinlibc. ## Porting Packages -- cgit v1.2.3 From 15fadbf1b22369b3d00b72f10643c63a17273f28 Mon Sep 17 00:00:00 2001 From: teythoon Date: Tue, 22 Oct 2013 17:49:14 +0200 Subject: Add small hack entry about fixing /proc/self. --- contributing.mdwn | 1 + 1 file changed, 1 insertion(+) diff --git a/contributing.mdwn b/contributing.mdwn index db2d77c6..cfc4dc0e 100644 --- a/contributing.mdwn +++ b/contributing.mdwn @@ -112,6 +112,7 @@ basic port could be small. See also the discussions on [[open_issues/exec]]. * Add `/proc/$pid/maps`. `vminfo` already has this kind of information, it's a matter of making procfs do the same. [[!GNU_Savannah_bug 32770]] * Move the mount/umount logic from utils/{,u}mount.c into libshouldbeinlibc. +* Fix /proc/self. Look at the file hurd/lookup-retry.c in the glibc source code for how FS_RETRY_MAGICAL lookups work. ## Porting Packages -- cgit v1.2.3 From 52e9ef870d362b5fd0a44653beb1a4c094e4d615 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 10 Nov 2013 00:21:08 +0100 Subject: Fix memleak --- user/tlecarrour/porting_guide_for_dummies.mdwn | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/user/tlecarrour/porting_guide_for_dummies.mdwn b/user/tlecarrour/porting_guide_for_dummies.mdwn index 64f0ba0d..cdab3508 100644 --- a/user/tlecarrour/porting_guide_for_dummies.mdwn +++ b/user/tlecarrour/porting_guide_for_dummies.mdwn @@ -217,8 +217,10 @@ The code comes from [[https://buildsecurityin.us-cert.gov/bsi/articles/knowledge if (buff == NULL) return NULL; int nchars = readlink(filename, buff, size); - if (nchars < 0) + if (nchars < 0) { + free(buff); return NULL; + } if (nchars < size) { buff[nchars] = '\0'; return buff; -- cgit v1.2.3