From c4ad3f73033c7e0511c3e7df961e1232cc503478 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 26 Feb 2014 12:32:06 +0100 Subject: IRC. --- .../mach/gnumach/projects/clean_up_the_code.mdwn | 111 ++++++++++++++++++++- 1 file changed, 107 insertions(+), 4 deletions(-) (limited to 'microkernel/mach/gnumach/projects') diff --git a/microkernel/mach/gnumach/projects/clean_up_the_code.mdwn b/microkernel/mach/gnumach/projects/clean_up_the_code.mdwn index 89a27b01..0ca6d91e 100644 --- a/microkernel/mach/gnumach/projects/clean_up_the_code.mdwn +++ b/microkernel/mach/gnumach/projects/clean_up_the_code.mdwn @@ -1,13 +1,13 @@ -[[!meta copyright="Copyright © 2005, 2006, 2007, 2008, 2010, 2012 Free Software -Foundation, Inc."]] +[[!meta copyright="Copyright © 2005, 2006, 2007, 2008, 2010, 2012, 2013, 2014 +Free Software Foundation, Inc."]] [[!meta license="""[[!toggle id="license" text="GFDL 1.2+"]][[!toggleable id="license" text="Permission is granted to copy, distribute and/or modify this document under the terms of the GNU Free Documentation License, Version 1.2 or any later version published by the Free Software Foundation; with no Invariant Sections, no Front-Cover Texts, and no Back-Cover Texts. A copy of the license -is included in the section entitled -[[GNU Free Documentation License|/fdl]]."]]"""]] +is included in the section entitled [[GNU Free Documentation +License|/fdl]]."]]"""]] [[!tag open_issue_gnumach]] @@ -130,3 +130,106 @@ further files (also exported ones) that serve no real value, but are being this parameter has name data_count that's one of the reasons mach is confusing i can't really tell you why, it's messy :/ + + +# [[open_issues/Code_Analysis]], *Coverity* + +## IRC, freenode, #hurd, 2014-02-03 + + braunr: at the end of kmem_cache_error the comment says 'never + reached'. i do not believe that to be true... + teythoon: yes, this is a mistake + those kmem_error calls were panics in the original version + the comment was left over + or rather, the panic equivalent not added + + +### IRC, freenode, #hurd, 2014-02-04 + + braunr: but the code relies uppon the fact that kmem_cache_error + does not return + the fact that it doesn't upsets static analysis tools + + http://darnassus.sceen.net/~teythoon/qa/gnumach/scan-build/2014-01-17/report-DfjC43.html#Path9 + 21:20 < braunr> or rather, the panic equivalent not added + teythoon: you're right + it needs to be fixed + i setup a coverity project for gnu mach + it's interesting + very enterprisy >,< + teythoon: heh + braunr: i assume kmem_error is supposed to panic + if so, i'd propose to use panic instead of printf in that macro + definition + yes + teythoon: again, that's how it's done in the original + implementation + and fix kmem_cache_error to use kmem_warn near the top of the + function + teythoon: i suggest you use the x15 variant as a reference + (http://git.sceen.net/rbraun/x15.git/blob/HEAD:/kern/kmem.c) + right + + +### IRC, OFTC, #debian-hurd, 2014-02-05 + + ah, cool. + is now in place. :) + pere: it was you who made me create the coverity project + and it was most fruitful already + glad to hear that. :) + while the mach thread made me discover scan-build, which + seem promising but have way to few rules. + teythoon: btw, could I get access to the mach coverity + status? + pere: sure + I've used up all my 'join project' slots, so I suspect you + have to invite me. try pere@hungry.com + pere: ok + pere: i'm fuzzy about the roles + what kind of invite shall i send you ? + not sure either. + ok + contributor/* would be fine for me. want to check the + details, not just the overview. + oh + * pere looked up the role description + do you have a link ? + i can always change the role afaics + go to the member list, found it there. + (the link is project specific, it seem. + right, found it + gah, it gave me a new user. :( + I assumed I would be allowed to accept the invite using my + normal user. + can you try again with pere-github@hungry.com, which + hopefully will hook the invite to my github authenticated user? + sure + were you allowed to invite that address? + ah, I got it in my dashboard without having to do anything + more. + heh, the email I got claimed the user would not be created + unless I provided a password, but given the member list for mach, + I fail to see how that could be true. + + +### IRC, OFTC, #debian-hurd, 2014-02-06 + + pere: your coverity invitations are still saying 'not + accepted', did neither work ? + teythoon: one worked just fine. I got access. the other I + did not accept. + pere: good :) + + +### IRC, OFTC, #debian-hurd, 2014-02-25 + + I am quite impressed with the defect density of Mach, . :) + 12 outstanding issues (but 54 dismissed was surprisingly + high :). + pere: 54 dismissed because that's a pattern generated by + mig + repeated dozens of times + +[[!tag open_issue_mig]] -- cgit v1.2.3